Proxy for download

[romankh]

Hi,

we are running embedded-elasticsearch on Jenkins CI, which is restricted to have access to the internet only via a proxy. This is not an unusual setup in business environments.

Also in

embedded-elasticsearch/core/src/main/java/pl/allegro/tech/embeddedelasticsearch/ElasticSearchInstaller.java

Line 156 in b502a85

FileUtils.copyURLToFile(source, target);

there is no timeout configured, so the build job keeps running and waiting for the connection to get established.

I think there should be an option in the builder like withDownloadProxy(String proxy) that enables users to set a proxy that can be used for downloading the distribution package.

This probably also is a resolution for #16.

[chrisbmoore]

I'd like this too. My temporary workaround is to host the elastic search zip file locally on my intranet and specify the url via withDownloadUrl().

[gaczm]

Hi,
As for timeout I agree. It's huge mistake from me. Sorry for that. I will set default download timeout and make it configurable via builder. And as for withDownloadProxy. How should it work? Simple url prefix will be enough?

[romankh]

I think best solution would be something like that:

.withDownloadProxy("proxy-hostname:8080")

and the downloader would do something like in this code example here

If no proxy set, they just proceed with FileUtils.copyURLToFile as before,
else they download via proxy:

public static void copyURLToFile(URL source, File destination, Proxy proxy) throws IOException {
        if(proxy == null) {
            FileUtils.copyURLToFile(source, destination);
        } else {
            downloadUsingProxy(source, destination, proxy);
        }
    }

[gaczm]

Ok, I've added methods for setting timeouts and proxy for downloading. It will be available in version 2.6.0

[chrisbmoore]

I can confirm this works now in 2.7.0

My example code:

try {
        Resource jsonMappingResource = resourceLoader.getResource("classpath:\\models\\elasticSearchDoc.json");

	String proxyAddress = "xxx.xxx.xxx.xx";
	int proxyPort = 80;
	Proxy downloadProxy = new Proxy(Type.HTTP, new InetSocketAddress(proxyAddress, proxyPort));

	this.elasticSearchBuilder = EmbeddedElastic.builder()
		.withElasticVersion("6.2.4")
		.withDownloadProxy(downloadProxy)
		.withSetting(PopularProperties.HTTP_PORT, 9200)
		.withSetting(PopularProperties.CLUSTER_NAME, "my_cluster").withPlugin("analysis-stempel")
		.withStartTimeout(60, TimeUnit.SECONDS)
		.withIndex(this.indexName, IndexSettings.builder().withType("_doc", jsonMappingResource.getInputStream()).build())
		.build().start();
} catch (InterruptedException e) {
	// TODO Auto-generated catch block
	e.printStackTrace();
}