fix: default commitConvention to 'none' #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@allcontributors[bot] please add ehmicky for code. |
|
I've put up a pull request to add @ehmicky! 🎉 |
Berkmann18
approved these changes
Apr 18, 2019
|
🎉 This PR is included in version 6.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Berkmann18
pushed a commit
that referenced
this pull request
May 24, 2020
* chore(package): update serverless to version 1.39.1 * chore(package): update lockfile yarn.lock * infra: unpin serverless version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default
config.commitConventiontonone.At the moment,
config.commitConventiononly defaults tononeduring the configuration generation. If the configuration has been generated using an older version ofall-contributors-cli, that value will beundefined. This eventually leads the following line to crash withCannot read property 'msg' of undefined. That line is triggered when adding new contributors.When the configuration file is read, if
commitConventionisundefined, it is set tonone.Checklist: