Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility issue #137

Closed
Berkmann18 opened this issue Jan 14, 2019 · 1 comment · Fixed by #138
Closed

Accessibility issue #137

Berkmann18 opened this issue Jan 14, 2019 · 1 comment · Fixed by #138
Labels
released

Comments

@Berkmann18
Copy link
Member

Berkmann18 commented Jan 14, 2019 •
edited
Loading

  • all-contributors-cli version: 5.7.0
  • node version: 11.0.0
  • npm (or yarn) version: 6.5.0

Relevant code or config

N/A

What you did:
Generated the contributors list

What happened:

It generated the list as expected.

Reproduction repository:

all-contributors generate

Problem description:

When the contributors table is generated, the images (read <img .../> tags) are missing an alt attribute which gets flagged on accessibility linters.
The reason for that is that images with no alt attribute can be hard/impossible to read on devices/systems for those with accessibility issues where page contents are read to them (think if the image wasn't visible, what would you rather see: nothing or a text explaining the image?).

Suggested solution:
It's not that big of an issue however as a developer who cares about accessibility, I think it would be a good idea to ensure that img tags include something like: alt="ContributorName" or something.

I'll open a PR in a few hours.
@Berkmann18 Berkmann18 mentioned this issue Jan 14, 2019
Merged
4 tasks
@all-contributors-release-bot
Copy link
Member

🎉 This issue has been resolved in version 5.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Berkmann18 pushed a commit that referenced this issue May 24, 2020
@sinchang @jakebolam
infra(package): update all-contributors-cli to version 6.1.2 (#154)
eca8aa2 
* fix(package): update all-contributors-cli to version 6.1.2

Closes #137

* chore(package): update lockfile yarn.lock

* Update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(format-contributor): added alt attributes
2 participants
@Berkmann18 @all-contributors-release-bot