Revert "feat: support commit comments (#180)" (#182)

This reverts commit a7dd869.
all-contributors · Mar 22, 2019 · f1e10fe · f1e10fe
1 parent a7dd869
commit f1e10fe
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 353 deletions.
diff --git a/app.yml b/app.yml
@@ -15,7 +15,7 @@
 default_events:
 # - check_run
 # - check_suite
-- commit_comment
+# - commit_comment
 # - create
 # - delete
 # - deployment

diff --git a/src/serverless-webhook.js b/src/serverless-webhook.js
@@ -61,11 +61,10 @@ module.exports.handler = thundra(async (event, context) => {
         }
     }
 
-    const isComment = name === 'issue_comment' || name === 'commit_comment'
-    if (!isComment) {
+    if (name !== 'issue_comment') {
         return {
             statusCode: 201,
-            body: 'Not a comment, exiting',
+            body: 'Not an issue comment, exiting',
         }
     }
 

diff --git a/src/tasks/processIssueComment/CommentReply/index.js b/src/tasks/processIssueComment/CommentReply/index.js
@@ -28,24 +28,6 @@ class CommentReply {
         const fromUser = this.replyingToWho()
         const body = `@${fromUser} ${this.message}`
         this.context.log.info(`Sending comment: ${body}`)
-
-        const isCommitComment = !!this.context.payload.comment.commit_id
-        if (isCommitComment) {
-            const {
-                commit_id: sha,
-                path,
-                position,
-            } = this.context.payload.comment
-
-            return this.context.github.repos.createCommitComment({
-                ...this.context.repo(),
-                sha,
-                body,
-                path: path ? path : undefined,
-                position: position ? position : undefined,
-            })
-        }
-
         const issueComment = this.context.issue({ body })
         return this.context.github.issues.createComment(issueComment)
     }

diff --git a/src/tasks/processIssueComment/probot-processIssueComment.js b/src/tasks/processIssueComment/probot-processIssueComment.js
@@ -215,11 +215,6 @@ function processIssueCommentApp(app) {
         app.log.trace(context)
         await probotProcessIssueCommentSafe({ context })
     })
-
-    app.on('commit_comment.created', async context => {
-        app.log.trace(context)
-        await probotProcessIssueCommentSafe({ context })
-    })
 }
 
 module.exports = processIssueCommentApp
diff --git a/test/fixtures/commit_comment.created.json b/test/fixtures/commit_comment.created.json
diff --git a/test/serverless-webhook.test.js b/test/serverless-webhook.test.js
@@ -26,32 +26,18 @@ describe('Serverless Webhook', () => {
         // TODO: expect lambda.invoke TO NOT BE CALLED
     })
 
-    test('If not a comment (or commit_comment), exit', async () => {
+    test('If not an issue comment, exit', async () => {
         const mockEvent = {
             headers: {
                 'x-github-event': 'lol',
             },
         }
         const response = await serverlessWebhookHandler(mockEvent, mockContext)
-        expect(response.body).toEqual('Not a comment, exiting')
+        expect(response.body).toEqual('Not an issue comment, exiting')
         // TODO: expect lambda.invoke TO NOT BE CALLED
     })
 
-    test('If a comment, but not created, exit', async () => {
-        const mockEvent = {
-            headers: {
-                'x-github-event': 'issue_comment',
-            },
-            body: {
-                action: 'edited',
-            },
-        }
-        const response = await serverlessWebhookHandler(mockEvent, mockContext)
-        expect(response.body).toEqual('Not a comment creation, exiting')
-        // TODO: expect lambda.invoke TO NOT BE CALLED
-    })
-
-    test('If a commit comment, but not created, exit', async () => {
+    test('If an issue comment, but not created, exit', async () => {
         const mockEvent = {
             headers: {
                 'x-github-event': 'issue_comment',
@@ -82,7 +68,7 @@ describe('Serverless Webhook', () => {
         // TODO: expect lambda.invoke TO NOT BE CALLED
     })
 
-    test('Issue Comment, If not for us, exit', async () => {
+    test('If not for us, exit', async () => {
         const mockEvent = {
             headers: {
                 'x-github-event': 'issue_comment',
@@ -102,26 +88,6 @@ describe('Serverless Webhook', () => {
         // TODO: expect lambda.invoke TO NOT BE CALLED
     })
 
-    test('Commit Comment, If not for us, exit', async () => {
-        const mockEvent = {
-            headers: {
-                'x-github-event': 'commit_comment',
-            },
-            body: {
-                action: 'created',
-                sender: {
-                    type: 'User',
-                },
-                comment: {
-                    body: 'Message not for us, exiting',
-                },
-            },
-        }
-        const response = await serverlessWebhookHandler(mockEvent, mockContext)
-        expect(response.body).toEqual('Message not for us, exiting')
-        // TODO: expect lambda.invoke TO NOT BE CALLED
-    })
-
     // test('If User and for us, take it', async () => {
     //     const mockEvent = {
     //         headers: {