Feaure-flagging LED effects (pyo3) #2
Comments
|
Hello! I was thinking about adding such a feature flag (third-party dependencies are indeed a pain on embedded platforms). As you've noticed the effect feature does creep up everywhere so feature-gating it does get ugly quite fast. Thanks for doing the initial work, I'll review it in more detail in the coming days and let you know how we could proceed! |
alixinne
added a commit
that referenced
this issue
Jan 29, 2022
Disabling the python features removes the dependency on Python libraries. Effects defined using a Python script will not be loaded if this feature is disabled. Fixes #2.
alixinne
added a commit
that referenced
this issue
Jan 29, 2022
Disabling the python features removes the dependency on Python libraries. Effects defined using a Python script will not be loaded if this feature is disabled. Fixes #2.
tuxuser
pushed a commit
to tuxuser/hyperion.rs
that referenced
this issue
Feb 12, 2022
Disabling the python features removes the dependency on Python libraries. Effects defined using a Python script will not be loaded if this feature is disabled. Fixes alixinne#2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey!
How do you think about feature-flagging the python-dependant component "effects"?
It certainly helps the build process on embedded platforms ;)
Here is an example branch, implementing the feature
effects: https://github.com/tuxuser/hyperion.rs/tree/task/feature_flag/py3(the branch additionally adds another build target)
Do you consider it useful? And if so, how shall we proceed?
cheers
The text was updated successfully, but these errors were encountered: