Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bongo cat #2

Merged
merged 8 commits into from
Sep 30, 2022
Merged

Bongo cat #2

merged 8 commits into from
Sep 30, 2022

Conversation

alinelena
Copy link
Owner

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half
  • Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • .conf file has optional extra features commented out
  • Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

droghio and others added 8 commits September 11, 2022 13:00
@droghio @petejohanson
fix(usb): add USB_DC_RESUME to supported states
6124d25 
All credit for this one goes to @xudongzheng (thanks for helping debug
this!). Should fix the issue where keyboards go unresponsive after their
host machine wakes from sleep due to the USB driver entering an error
state. I was able to both reliably reproduce the issue before the patch
goes in and confirmed it no longer occurs post patch.

The `USB_DC_RESUME` state indicates the host event has resumed the connection.
Adding it to the list of valid connection states to prevent the error
when waking from sleep.

Zephyr API Link:
https://docs.zephyrproject.org/apidoc/latest/group____usb__device__controller__api.html#gac09e3e0af1a2b41a5bfbad91f900baf7

fixes zmkfirmware#1372
@urob
fix(docs): Fix ambiguous tap-preferred desc.
3f28a55
@nguyendown
feat(widget): add bongo cat
5513f16
@nguyendown
feat(widget): bongo cat is now interactive only
79bac9d
@nguyendown
fix(widget): reorder code
6e010d1
@nguyendown
fix(widget): reorder code, add comments
1b5e5bb
@nguyendown
fix(widgets): no need to set the same state
3167822
@nguyendown
add license info
15b703e
@alinelena alinelena merged commit 15b703e into alinelena:ll Sep 30, 2022
alinelena pushed a commit that referenced this pull request Mar 9, 2024
@caksoylar
fix(docs): Fix remark on &bt parameter #2
12d73ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alinelena @droghio @urob @nguyendown