Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(com-pwa): page-product-list and enhance renders #652

Merged
merged 10 commits into from
Feb 15, 2023

Conversation

MM25Zamanian
Copy link
Contributor

PR Checklist

@MM25Zamanian MM25Zamanian added the enhancement Enhancement of the code, not introducing new features. label Jan 14, 2023
@MM25Zamanian MM25Zamanian self-assigned this Jan 14, 2023
@MM25Zamanian MM25Zamanian requested a review from alimd as a code owner January 14, 2023 13:21
@MM25Zamanian
Copy link
Contributor Author

یه جا هایی فقط برای تسته
مثل دست کاری کردن راستچین صفحه یا ...

@alimd alimd force-pushed the feat/demo-pwa/products branch 2 times, most recently from 729185b to 66e5e99 Compare February 13, 2023 13:18
}
}

function test_for_in(): void {

Check failure

Code scanning / ESLint

Enforce camelcase naming convention

Identifier 'test_for_in' is not in camel case.
}
}

function test_for_of_values(): void {

Check failure

Code scanning / ESLint

Enforce camelcase naming convention

Identifier 'test_for_of_values' is not in camel case.
}
}

function test_for_of_keys(): void {

Check failure

Code scanning / ESLint

Enforce camelcase naming convention

Identifier 'test_for_of_keys' is not in camel case.
@alimd alimd changed the title feat(ui/demo-pwa/page-products): new page feat(ui-kit): product-card / page Feb 14, 2023
@alimd alimd changed the title feat(ui-kit): product-card / page feat(com-pwa): page-product-list Feb 14, 2023
@alimd alimd force-pushed the feat/demo-pwa/products branch 3 times, most recently from 9457e26 to 5bf75e9 Compare February 15, 2023 10:46
<div class="price">
<del>${number(this.content.price)}</del>
<ins>${number(this.content.finalPrice)}</ins>
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 14 14"><path fill-rule="evenodd" stroke="none" fill="currentcolor" d="M3.057 1.742L3.821 1l.78.75-.776.741-.768-.749zm3.23 2.48c0 .622-.16 1.111-.478 1.467-.201.221-.462.39-.783.505a3.251 3.251 0 01-1.083.163h-.555c-.421 0-.801-.074-1.139-.223a2.045 2.045 0 01-.9-.738A2.238 2.238 0 011 4.148c0-.059.001-.117.004-.176.03-.55.204-1.158.525-1.827l1.095.484c-.257.532-.397 1-.419 1.403-.002.04-.004.08-.004.12 0 .252.055.458.166.618a.887.887 0 00.5.354c.085.028.178.048.278.06.079.01.16.014.243.014h.555c.458 0 .769-.081.933-.244.14-.139.21-.383.21-.731V2.02h1.2v2.202zm5.433 3.184l-.72-.7.709-.706.735.707-.724.7zm-2.856.308c.542 0 .973.19 1.293.569.297.346.445.777.445 1.293v.364h.18v-.004h.41c.221 0 .377-.028.467-.084.093-.055.14-.14.14-.258v-.069c.004-.243.017-1.044 0-1.115L13 8.05v1.574a1.4 1.4 0 01-.287.863c-.306.405-.804.607-1.495.607h-.627c-.061.733-.434 1.257-1.117 1.573-.267.122-.58.21-.937.265a5.845 5.845 0 01-.914.067v-1.159c.612 0 1.072-.082 1.38-.247.25-.132.376-.298.376-.499h-.515c-.436 0-.807-.113-1.113-.339-.367-.273-.55-.667-.55-1.18 0-.488.122-.901.367-1.24.296-.415.728-.622 1.296-.622zm.533 2.226v-.364c0-.217-.048-.389-.143-.516a.464.464 0 00-.39-.187.478.478 0 00-.396.187.705.705 0 00-.136.449.65.65 0 00.003.067c.008.125.066.22.177.283.093.054.21.08.352.08h.533zM9.5 6.707l.72.7.724-.7L10.209 6l-.709.707zm-6.694 4.888h.03c.433-.01.745-.106.937-.29.024.012.065.035.12.068l.074.039.081.042c.135.073.261.133.379.18.345.146.67.22.977.22a1.216 1.216 0 00.87-.34c.3-.285.449-.714.449-1.286a2.19 2.19 0 00-.335-1.145c-.299-.457-.732-.685-1.3-.685-.502 0-.916.192-1.242.575-.113.132-.21.284-.294.456-.032.062-.06.125-.084.191a.504.504 0 00-.03.078 1.67 1.67 0 00-.022.06c-.103.309-.171.485-.205.53-.072.09-.214.14-.427.147-.123-.005-.209-.03-.256-.076-.057-.054-.085-.153-.085-.297V7l-1.201-.5v3.562c0 .261.048.496.143.703.071.158.168.296.29.413.123.118.266.211.43.28.198.084.42.13.665.136v.001h.036zm2.752-1.014a.778.778 0 00.044-.353.868.868 0 00-.165-.47c-.1-.134-.217-.201-.35-.201-.18 0-.33.103-.447.31-.042.071-.08.158-.114.262a2.434 2.434 0 00-.04.12l-.015.053-.015.046c.142.118.323.216.544.293.18.062.325.092.433.092.044 0 .086-.05.125-.152z"></path></svg>

Check failure

Code scanning / ESLint

Enforce a maximum line length

This line has a length of 2249. Maximum allowed is 120.
@alimd alimd force-pushed the feat/demo-pwa/products branch from c60b347 to cc88c03 Compare February 15, 2023 10:57
@alimd alimd force-pushed the feat/demo-pwa/products branch 2 times, most recently from 6a06113 to 09f0b8a Compare February 15, 2023 11:21
@alimd alimd changed the title feat(com-pwa): page-product-list feat(com-pwa): page-product-list and enhance renders Feb 15, 2023
@alimd alimd merged commit 64dff67 into next Feb 15, 2023
@alimd alimd deleted the feat/demo-pwa/products branch February 15, 2023 11:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants