Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validator #534

Merged
merged 23 commits into from
Jan 3, 2023
Merged

feat: validator #534

merged 23 commits into from
Jan 3, 2023
+329 −1

Conversation

njfamirm
Copy link
Member

No description provided.

@njfamirm njfamirm added the new-feature New features or options. label Dec 21, 2022
@njfamirm njfamirm added this to the v0.x milestone Dec 21, 2022
@njfamirm njfamirm self-assigned this Dec 21, 2022
@njfamirm njfamirm requested a review from alimd as a code owner December 21, 2022 06:55
alimd
alimd reviewed Dec 21, 2022
View reviewed changes
alimd
alimd reviewed Dec 21, 2022
View reviewed changes
Copy link
Member

@alimd alimd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

تا اینجا خوبه
اولیت فعلی ادامه ui هستش ولی هر زمان تنها بودی اینو ادامه بده و یک پکیج جدا بشه
اسم متغییر ها کلا باز نویسی بشه و مفهومی تر و میتونی از ajv هم الگو بگیری
و بعد تو دل نانو سرور ازش استفاده بشه
ساختار خطاها هم طوری باشه که نانو سرور بتونه ازش استفاده کنه

@njfamirm
Copy link
Member Author

طبق صحبت ها با مستقیم دیتا رو بدیم به ارور

alimd
alimd reviewed Dec 24, 2022
View reviewed changes
alimd
alimd reviewed Dec 24, 2022
View reviewed changes
alimd
alimd approved these changes Dec 24, 2022
View reviewed changes
Copy link
Member

@alimd alimd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

احسنت
خیلی عالی و ترو تمیز شد
فعلا مرج نکن تا دقیقتر تستش کنم

@njfamirm
Copy link
Member Author

هنوز تمومش نشده خب...
کار داره

@njfamirm njfamirm marked this pull request as draft December 25, 2022 02:09
@alimd
Copy link
Member

alimd commented Dec 30, 2022

@njfamirm
اینو ولش کردی؟!

@njfamirm
Copy link
Member Author

در انتظار ریویو
البته تایم نداشتم ادامه بدم

@njfamirm njfamirm marked this pull request as ready for review December 31, 2022 08:55
@alimd alimd force-pushed the feat/validator branch 3 times, most recently from e529701 to adf7618 Compare January 1, 2023 12:56
@alimd alimd merged commit 19e1e0e into next Jan 3, 2023
@alimd alimd deleted the feat/validator branch January 3, 2023 13:54
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Pull Request closed and locked due to lack of activity.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alimd alimd alimd approved these changes

Assignees

@njfamirm njfamirm

Labels
new-feature New features or options.
Projects
None yet
Milestone
v0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@njfamirm @alimd