Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signal set porvider issue #222

Merged
merged 7 commits into from
Aug 24, 2022
Merged

Conversation

mohammadhonarvar
Copy link
Member

@mohammadhonarvar mohammadhonarvar commented Aug 23, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes #(issue)

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

@mohammadhonarvar mohammadhonarvar added this to the v1.0.0-beta milestone Aug 23, 2022
@mohammadhonarvar mohammadhonarvar requested a review from alimd August 23, 2022 15:32
@mohammadhonarvar mohammadhonarvar self-assigned this Aug 23, 2022
@alimd alimd changed the title Feature/signal set porvider issue Fix signal set porvider issue Aug 24, 2022
Copy link
Member

@alimd alimd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

کافی بعد ورودی _setSignalProvider رو تغییر بدی

@alimd alimd force-pushed the feature/signal-set-porvider-issue branch from 9afdcf2 to 4d1237c Compare August 24, 2022 11:47
@mohammadhonarvar
Copy link
Member Author

خخخ
به جان خودم میخواستم همینکارو بکنم ولی گفتم شاید بگید چرا پارامتر ورودی اون اضافه بشه!!

@alimd alimd merged commit 69aa040 into next Aug 24, 2022
@alimd alimd deleted the feature/signal-set-porvider-issue branch August 24, 2022 16:46
@github-actions
Copy link

Pull Request closed and locked due to lack of activity.
If you'd like to build on this closed PR, you can clone it using this method: https://stackoverflow.com/a/14969986
Then open a new PR, referencing this closed PR in your message.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants