Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods in ImageMatching and features in StructureFromMotion and FeatureMatching #768

Merged
merged 5 commits into from
Feb 4, 2020
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions meshroom/nodes/aliceVision/FeatureMatching.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,16 @@ class FeatureMatching(desc.CommandLineNode):
uid=[0],
advanced=True,
),
desc.FloatParam(
name='knownPosesGeometricErrorMax',
label='Known Poses Geometric Error Max',
description='Maximum error (in pixels) allowed for features matching guided by geometric information from known camera poses.\n'
'If set to 0 it lets the ACRansac select an optimal value.',
value=5.0,
range=(0.0, 100.0, 1.0),
uid=[0],
advanced=True,
),
desc.IntParam(
name='maxMatches',
label='Max Matches',
Expand All @@ -140,6 +150,14 @@ class FeatureMatching(desc.CommandLineNode):
value=False,
uid=[0],
),
desc.BoolParam(
name='matchFromKnownCameraPoses',
label='Match From Known Camera Poses',
description='Enable the usage of geometric information from known camera poses to guide the feature matching.\n'
'If some cameras have unknown poses (so there is no geometric prior), the standard feature matching will be performed.',
value=False,
uid=[0],
),
desc.BoolParam(
name='exportDebugFiles',
label='Export Debug Files',
Expand Down
20 changes: 19 additions & 1 deletion meshroom/nodes/aliceVision/ImageMatching.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
__version__ = "1.0"
__version__ = "1.1"

import os
from meshroom.core import desc
Expand Down Expand Up @@ -28,6 +28,15 @@ class ImageMatching(desc.CommandLineNode):
label="Features Folders",
description="Folder(s) containing the extracted features and descriptors."
),
desc.ChoiceParam(
name='method',
label='Method',
description='Method used to select the image pairs to match.',
value='VocabularyTree',
values=['VocabularyTree', 'Sequential', 'SequentialAndVocabularyTree','Exhaustive','Frustum'],
exclusive=True,
uid=[0],
),
desc.File(
name='tree',
label='Tree',
Expand Down Expand Up @@ -70,6 +79,15 @@ class ImageMatching(desc.CommandLineNode):
uid=[0],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label='VocTree: Nb Matches'
And same for all the other params

advanced=True,
),
desc.IntParam(
name='nbNeighbors',
label='Nb Neighbors',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label='Sequential: Nb Neighbors',

description='The number of neighbors to retrieve for each image (If 0 it will retrieve all the neighbors).',
value=50,
range=(0, 1000, 1),
uid=[0],
advanced=True,
),
desc.ChoiceParam(
name='verboseLevel',
label='Verbose Level',
Expand Down
17 changes: 17 additions & 0 deletions meshroom/nodes/aliceVision/StructureFromMotion.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,15 @@ class StructureFromMotion(desc.CommandLineNode):
range=(0, 50000, 1),
uid=[0],
),
desc.IntParam(
name='minNumberOfMatches',
label='Minimum Number of Matches',
description='Minimum number of matches per image pair (and per feature type). \n'
'This can be useful to have a meaningful reconstruction with accurate keypoints. 0 means no limit.',
value=0,
range=(0, 50000, 1),
uid=[0],
),
desc.IntParam(
name='minInputTrackLength',
label='Min Input Track Length',
Expand Down Expand Up @@ -207,6 +216,14 @@ class StructureFromMotion(desc.CommandLineNode):
value=False,
uid=[0],
),
desc.BoolParam(
name='filterTrackForks',
label='Filter Track Forks',
description='Enable/Disable the track forks removal. A track contains a fork when incoherent matches \n'
'lead to multiple features in the same image for a single track. \n',
value=True,
uid=[0],
),
desc.File(
name='initialPairA',
label='Initial Pair A',
Expand Down