[ui][fix] Edge: Fixing an issue with mouse event on Custom EdgeMouseArea causing Crash #2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2650 +/- ##
========================================
Coverage 69.93% 69.93%
========================================
Files 121 121
Lines 7088 7088
========================================
Hits 4957 4957
Misses 2131 2131 ☔ View full report in Codecov by Sentry. |
waaake
force-pushed
the
fix/CrashingEdge
branch
2 times, most recently
from
6dc4ef0 to
5a116b4
Compare
With Qt6 the geometryChanged method was updated to be called as geometryChange and with that update QQuickItem was not getting internal updateShape to get invoked upon updates
waaake
force-pushed
the
fix/CrashingEdge
branch
from
5a116b4 to
49ceb6e
Compare
yann-lty
reviewed
Jan 24, 2025
| @@ -149,7 +149,7 @@ Item { | |||
| /* The curve scale must be set only once the component has been fully created, so | |||
| * that all the events following the update of the curve scale can be taken into | |||
| * account. */ | |||
| curveScale = Qt.binding(() => cubic.ctrlPtDist / root.width) // Normalize by width | |||
| curveScale = cubic.ctrlPtDist / root.width // Normalize by width | |||
There was a problem hiding this comment.
That can be moved back to a normal binding in the edgeArea (we don't need the Component.onCompleted anymore).
curveScale: cubic.ctrlPtDist / root.width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event::button() was sometimes causing a crash, copying the event and using event.buttons() from the copied event seems to be stable before calling event.button() eventuallyDescription
This PR addresses a known crash issue with the EdgeMouseArea (QQuickItem)'s mousePressEvent.
The crash occurs when querying button() from the event.
The event is not null and is able to provide other data correctly before ending up crashing when queried for button.
Features list
Implementation remarks
Current Fix is based on copying the provided event and calling event.buttons() to check if the buttons are supported and then calling button() is the custom MouseEvent constructor.This seems to have stopped the crashes for now, but still testing on larger scale is pending before we confirm anything.