Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodes] KeyframeSelection: Add support for masks #2167

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

cbentejac
Copy link
Contributor

@cbentejac cbentejac commented Aug 25, 2023

Description

This PR reflects changes made in alicevision/AliceVision#1518 and adds a new attribute, maskPaths, to the KeyframeSelection node.

Folders containing masks (e.g. segmentation masks) can be provided to that attribute to be applied during the score computation for the smart keyframe selection method.

@cbentejac cbentejac added this to the Meshroom 2023.3.0 milestone Aug 25, 2023
@cbentejac cbentejac self-assigned this Aug 25, 2023
…tion

Segmentation masks may be provided to exclude some parts of the frame
from the score computations if the smart method is selected.
@cbentejac cbentejac force-pushed the dev/keyframeMaskSupport branch from 7c4636a to b50a2fb Compare August 25, 2023 14:06
@cbentejac cbentejac marked this pull request as ready for review August 25, 2023 15:36
@cbentejac cbentejac added the invalidate:node Invalidates the cache of one or several nodes. label Aug 25, 2023
@mugulmd mugulmd merged commit 1a08d9f into develop Aug 28, 2023
@mugulmd mugulmd deleted the dev/keyframeMaskSupport branch August 28, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalidate:node Invalidates the cache of one or several nodes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants