[ui] Preserve last CameraInit index when updating the CameraInits list
#2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
requested changes
Sep 21, 2023
Prior to this commit, when a `CameraInit` node was added to or removed from the list of `CameraInit` nodes, the active `CameraInit` was always reset to the first one in the list, independently from its previous value. This commit changes that behaviour by only modifying the active `CameraInit` if no `CameraInit` node has been assigned yet, or if the active `CameraInit` does not exist anymore (meaning it has been removed). This requires to emit the `cameraInitChanged` signal every single time the list of existing `CameraInit` nodes is modified even if the active one is not changed, and to connect it to the ImageGallery in order to ensure the index from the combo box always corresponds to the currently active `CameraInit` node. Indeed, when the list of CameraInits is updated, the model for the combo box is reset, and it needs to be re-updated with the correct non-default value.
cbentejac
force-pushed
the
fix/cameraInitIdx
branch
from
136fa90 to
a606a8f
Compare
fabiencastan
reviewed
Oct 3, 2023
If all the CameraInits have been removed, then the test in |
fabiencastan
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this PR, when a
CameraInitnode was added to or removed from the list ofCameraInitnodes, the activeCameraInitwas always reset to the first one in the list, independently from its previous value. This meant that whenever aCameraInitnode was added to or removed from the graph while the Image Gallery was displaying aCameraInitnode that was not the first one in the list, the Image Gallery was automatically updated to display the firstCameraInitnode without any intervention from the user, as shown below:This pull request changes that behaviour by only modifying the active
CameraInitnode if noCameraInitnode has been assigned yet, or if the activeCameraInitnode does not exist anymore (meaning it has been removed).This requires to emit the
cameraInitChanged()signal every single time the list of existingCameraInitnodes is modified even if the active one remains the same, and to connect it to the ImageGallery in order to ensure the index from the combo box always corresponds to the currently activeCameraInitnode. Indeed, when the list of CameraInits is updated, themodel for the combo box is reset, and it needs to be re-updated with the correct non-default value.