[blender] preview: use Freestyle for line art shading #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mugulmd
force-pushed
the
mug/scenePreviewFreestyle
branch
from
f2aa4ed to
b3d2b18
Compare
cbentejac
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A regression on the
ScenePreviewnode was introduced in this PR: theline_artshading method was not working properly with Cycles.In this PR we fix this regression by replacing the former method with a new one that provides more flexibility for potential future refinements.
For that we simply use the Freestyle renderer: https://docs.blender.org/manual/fr/dev/render/freestyle/introduction.html