Viewer2D: Dynamically update the list of viewable outputs #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bled When a node with viewable output attributes is loaded, the combo box of the 2D Viewer lists these attributes. As some of these attributes are enabled or disabled, they need to be added or removed from that list, without needing to load another node first, or to unload the node. This commit connects the signal that is emitted when an output attribute with a viewable output is enabled or disabled to the slot that reloads the currently loaded node (and thus updates the list).
mugulmd
force-pushed
the
dev/updateViewerList
branch
from
5d45cfa to
4e130e7
Compare
mugulmd
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR splits from #1925 and keeps the dynamic update of the list of viewable outputs in the 2D Viewer: instead of displaying at all times the list of a node's viewable outputs independently from their current status (enabled or disabled), the 2D Viewer should only show the enabled outputs, and adding/removing them as soon as they get enabled/disabled.
Hiding (or showing) the connections of output attributes that get disabled (or enabled) will remain handled in #1925.
Features list
enabledstatus of someDepthMap's outputs.