[core] Include the node's type in the UID computation #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
changed the title
mugulmd
added
the
invalidate:graph
This prevents getting the same UID for two nodes which are of different types but have an identical list of attributes.
cbentejac
force-pushed
the
fix/nodeTypeInUid
branch
from
ff5cffd to
55d30ee
Compare
fabiencastan
approved these changes
Jun 14, 2023
2 tasks
mugulmd
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the node's type in the tuple of each attribute that is used to compute its UID. The goal is to prevent getting the same UID for two nodes which are of different types but have an identical list of attributes.