[ui] fix thumbnail cache bugs #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mugulmd
changed the title
mugulmd
force-pushed
the
mug/fixThumbnailCache
branch
from
39979a9 to
68d1172
Compare
fabiencastan
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we fix several bugs related to the thumbnail cache mechanism.
Endless request loop
We fix a problem that can occur with the thumbnail cache when input images cannot be read:
since each image delegate has a Timer that will send a new request every 5 seconds until a thumbnail can be loaded, in the case of images that cannot be read these requests will be sent endlessly.
The proposed fix is to stop the Timer after the 1st request, since it is the only one that is actually useful for preventing unwanted behaviour from the QML engine.
Reload image after modification
Another problem that we fixed is that when an image was loaded once, then modified for any reason and then reloaded later on, its corresponding thumbnail will not be updated.
The proposed fix is to remove a thumbnail if its corresponding image has been modified after the thumbnail creation: this way, a new thumbnail will be generated, and it will match the modified image.