[ui] fix "Sync Camera with Image Selection" #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mugulmd
requested review from
fabiencastan,
cbentejac and
servantftechnicolor
cbentejac
approved these changes
Feb 7, 2023
fabiencastan
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the "Sync Camera with Image Selection" feature in the 3D viewer.
Features
Implementation remarks
The image used as overlay is not exactly the input image but its undistorted version computed by the PrepareDenseScene node. This means that if the PrepareDenseScene node has not been computed or does not exist (for example in a CameraTracking pipeline), there won't be a background image.
A more robust solution should be imagined for handling such cases.