Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Elapsed time indicators in log #1787

Merged
merged 12 commits into from
Oct 12, 2022
Merged

[ui] Elapsed time indicators in log #1787

merged 12 commits into from
Oct 12, 2022

Conversation

mugulmd
Copy link
Contributor

@mugulmd mugulmd commented Sep 30, 2022

Description

The goal of this PR is to enrich the node log viewer so that finding the steps that require long calculations is easier for users. To achieve that, we retrieve the time value of each log-line (when it exists) and we display the elapsed time between consecutive time values.

We add 2 visual indicators:

  • a colored marker next to the line number
  • a tooltip when hovering over the line number cell displaying the elapsed time.

@mugulmd mugulmd self-assigned this Sep 30, 2022
@mugulmd
Copy link
Contributor Author

mugulmd commented Sep 30, 2022

For now there are still 2 main issues to work on that I noted:

  • the color scale for the markers is arbitrary and definitely requires some fine-tuning
  • when changing the chunk while displaying the log, the following QML warning appear: TextFileViewer.qml:274: TypeError: Value is undefined and could not be converted to an object

@fabiencastan
Copy link
Member

The colorbar should have the line height:
image

@fabiencastan
Copy link
Member

Time in tooltip should be formatted h:m:s.
The zone to display the Tooltip should include the colorbar.

@fabiencastan
Copy link
Member

Should interpolate colors.

@fabiencastan
Copy link
Member

The colorbar should be grey if the timing is 0 (and not the same than the background), so we can always see a continuous vertical line.

@mugulmd mugulmd marked this pull request as ready for review October 4, 2022 09:08
@fabiencastan fabiencastan added this to the Meshroom 2022.1.0 milestone Oct 12, 2022
@fabiencastan fabiencastan merged commit ab0e132 into develop Oct 12, 2022
@fabiencastan fabiencastan deleted the dev/lv/colorLog branch October 12, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants