Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optical center relative to the image center #1509

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Conversation

fabiencastan
Copy link
Member

Description

Meshroom-side implementation of alicevision/AliceVision#1072.

Features list

  • Update in CameraInit to match with AliceVision sfmData files 1.2.1
  • Upgrade code from 1.2.0 to 1.2.1

Implementation remarks

  • Fix the upggrade for the particular case of a linked ListAttribute

The principal point is no more relative to the top-left corner of the image.
Linked to the AliceVision sfmData IO change in file version 1.2.1.
@fabiencastan fabiencastan added this to the Meshroom 2021.2.0 milestone Aug 19, 2021
@fabiencastan fabiencastan merged commit 1a506f8 into develop Aug 19, 2021
@fabiencastan fabiencastan deleted the dev/offsetFromCenter branch August 19, 2021 08:22
fabiencastan added a commit that referenced this pull request Oct 14, 2021
Fix changes of principal point coord system from #1509.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant