Draft Reconstruction pipeline #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
reviewed
Sep 2, 2021
meshroom/ui/reconstruction.py
Outdated
| @@ -496,6 +496,9 @@ def new(self, pipeline=None): | |||
| elif p.lower() == "cameratracking": | |||
| # default camera tracking pipeline | |||
| self.setGraph(multiview.cameraTracking()) | |||
| elif p.lower() == "photogrammetrynocuda": | |||
| # default panorama fisheye hdr pipeline | |||
There was a problem hiding this comment.
Suggested change
| # default panorama fisheye hdr pipeline | |
| # draft mode for the photogrammetry pipeline that does not require cuda |
fabiencastan
reviewed
Sep 2, 2021
meshroom/ui/reconstruction.py
Outdated
| @@ -496,6 +496,9 @@ def new(self, pipeline=None): | |||
| elif p.lower() == "cameratracking": | |||
| # default camera tracking pipeline | |||
| self.setGraph(multiview.cameraTracking()) | |||
| elif p.lower() == "photogrammetrynocuda": | |||
There was a problem hiding this comment.
Would be better to name everything draft (instead of nocuda):
Suggested change
| elif p.lower() == "photogrammetrynocuda": | |
| elif p.lower() == "photogrammetrydraft": |
fcastan
force-pushed
the
dev_nocudapipeline
branch
from
6a73563 to
6888dd6
Compare
fcastan
force-pushed
the
dev_nocudapipeline
branch
from
6888dd6 to
d30571c
Compare
fabiencastan
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to easier the use of Meshroom for user who don't have an NVIDIA CUDA card, I think that it is important to be able to start a project with the appropriate pipeline without customing it manually.
Related with wiki page https://github.com/alicevision/meshroom/wiki/Draft-Meshing
Features list
Add File > New Pipeline > Photogrammetry (No CUDA)
Remarks
Use the same parameters than others pipelines
An alternative would be to alicevision/AliceVision#439 or to make it compatible with OpenMVS which doesn't need CUDA