Skip to content

Commit

Permalink
Merge pull request #2642 from alicevision/dev/sfmLidar
Browse files Browse the repository at this point in the history
Update sfm pipeline to accept meshes
  • Loading branch information
cbentejac authored Jan 20, 2025
2 parents 6071a91 + fce6ba1 commit 1f42ad3
Show file tree
Hide file tree
Showing 6 changed files with 48 additions and 8 deletions.
14 changes: 13 additions & 1 deletion meshroom/nodes/aliceVision/ExportMatches.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
__version__ = "1.1"
__version__ = "2.0"

from meshroom.core import desc
from meshroom.core.utils import DESCRIBER_TYPES, VERBOSE_LEVEL
Expand Down Expand Up @@ -50,6 +50,18 @@ class ExportMatches(desc.AVCommandLineNode):
label="Matches Folders",
description="Folder(s) in which computed matches are stored.",
),
desc.File(
name="filterA",
label="Filter A",
description="One item of the pair must match this.",
value="",
),
desc.File(
name="filterB",
label="Filter B",
description="One item of the pair must match this.",
value="",
),
desc.ChoiceParam(
name="verboseLevel",
label="Verbose Level",
Expand Down
18 changes: 17 additions & 1 deletion meshroom/nodes/aliceVision/RelativePoseEstimating.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
__version__ = "2.0"
__version__ = "3.0"

from meshroom.core import desc
from meshroom.core.utils import DESCRIBER_TYPES, VERBOSE_LEVEL
Expand Down Expand Up @@ -34,6 +34,22 @@ class RelativePoseEstimating(desc.AVCommandLineNode):
description="Enforce pure rotation as a model",
value=False,
),
desc.IntParam(
name="countIterations",
label="Ransac Max Iterations",
description="Maximal number of iterations.",
value=1024,
range=(1024, 500000, 1),
advanced=True,
),
desc.IntParam(
name="minInliers",
label="Ransac Min Inliers",
description="Minimal allowed inliers in two view relationship.",
value=35,
range=(1, 1000, 1),
advanced=True,
),
desc.ChoiceParam(
name="verboseLevel",
label="Verbose Level",
Expand Down
10 changes: 8 additions & 2 deletions meshroom/nodes/aliceVision/SfmBootstraping.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
__version__ = "2.0"
__version__ = "3.0"

from meshroom.core import desc
from meshroom.core.utils import DESCRIBER_TYPES, VERBOSE_LEVEL
from meshroom.core.utils import VERBOSE_LEVEL


class SfMBootStraping(desc.AVCommandLineNode):
Expand All @@ -25,6 +25,12 @@ class SfMBootStraping(desc.AVCommandLineNode):
description="Tracks file.",
value="",
),
desc.File(
name="meshFilename",
label="Mesh File",
description="Mesh file (*.obj).",
value="",
),
desc.File(
name="pairs",
label="Pairs File",
Expand Down
10 changes: 8 additions & 2 deletions meshroom/nodes/aliceVision/SfmExpanding.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
__version__ = "1.0"
__version__ = "2.0"

from meshroom.core import desc
from meshroom.core.utils import DESCRIBER_TYPES, VERBOSE_LEVEL
from meshroom.core.utils import VERBOSE_LEVEL


class SfMExpanding(desc.AVCommandLineNode):
Expand All @@ -28,6 +28,12 @@ class SfMExpanding(desc.AVCommandLineNode):
description="Tracks file.",
value="",
),
desc.File(
name="meshFilename",
label="Mesh File",
description="Mesh file (*.obj).",
value="",
),
desc.IntParam(
name="localizerEstimatorMaxIterations",
label="Localizer Max Ransac Iterations",
Expand Down
2 changes: 1 addition & 1 deletion meshroom/pipelines/nodalCameraTracking.mg
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"ImageSegmentationBox": "0.1",
"NodalSfM": "2.0",
"Publish": "1.3",
"RelativePoseEstimating": "2.0",
"RelativePoseEstimating": "3.0",
"ScenePreview": "2.0",
"TracksBuilding": "1.0"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"ImageSegmentationBox": "0.1",
"NodalSfM": "2.0",
"Publish": "1.3",
"RelativePoseEstimating": "2.0",
"RelativePoseEstimating": "3.0",
"ScenePreview": "2.0",
"TracksBuilding": "1.0"
}
Expand Down

0 comments on commit 1f42ad3

Please sign in to comment.