Add mesh utilities softwares #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to perform a boolean operation between two meshes
Use Geogram library in order to convert an input mesh to another mesh format.
gregoire-dl
changed the title
simogasp
reviewed
Feb 4, 2021
| bool preProcess = true; | ||
| bool postProcess = true; | ||
|
|
||
| po::options_description allParams("AliceVision mergeMeshes"); |
There was a problem hiding this comment.
Please specify better what the program does e.g. "The program takes two meshes and..."
simogasp
requested changes
Feb 4, 2021
| std::string inputMeshPath; | ||
| std::string outputFilePath; | ||
|
|
||
| po::options_description allParams("AliceVision convertMesh"); |
simogasp
reviewed
Feb 4, 2021
Comment on lines
+115
to
+126
| { | ||
| const std::string outputFolderPart = fs::path(outputFilePath).parent_path().string(); | ||
|
|
||
| if(!outputFolderPart.empty() && !fs::exists(outputFolderPart)) | ||
| { | ||
| if(!fs::create_directory(outputFolderPart)) | ||
| { | ||
| ALICEVISION_LOG_ERROR("Cannot create output folder"); | ||
| return EXIT_FAILURE; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
maybe we can refactor in function inside alicevision_system to be used in all the other exe
There was a problem hiding this comment.
It's a good idea. But maybe it's better to do that in another PR with a larger scope ?
There was a problem hiding this comment.
we can start with this one creating the function in the library and replacing the code in these 2.
I don't know how many other blocks are there like this one in the other binaries but it's a matter of search and replace
simogasp
reviewed
Feb 4, 2021
fabiencastan
approved these changes
Feb 11, 2021
fabiencastan
approved these changes
Feb 12, 2021
2 tasks
natowi
reviewed
Feb 12, 2021
| return "Operation types used to merge two meshes:\n" | ||
| "* boolean_union: Create a new mesh with the combined volume of the two input meshes.\n" | ||
| "* boolean_intersection: Create a new mesh from the intersected volumes of the two input meshes.\n" | ||
| "* boolean_difference: Create a new mesh from the volume of the first input mesh substracted by the second input mesh.\n"; |
There was a problem hiding this comment.
Typo: subtracted not substracted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add two softwares based on Geogram for mesh boolean operations and mesh conversion.
Features list
MergeMeshessoftwareConvertMeshsoftware