Manage LCP in imageProcessing #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demoulinv
force-pushed
the
dev/lcpInImageProcessing
branch
from
0214d63 to
d9975cf
Compare
Add getSensorSize method in View class: Combine metadata and sensor database info to extract the sensor height and width. Update getIntrinsic in viewIO by considering LCP data to initialize the coefficients of the distortion model. Add isEmpty method in LensParam class. Add method in View class to add vignetting info in metadata.
demoulinv
force-pushed
the
dev/lcpInImageProcessing
branch
from
6100166 to
d829d3c
Compare
Update the software version following the addition of new LCP-related parameters to the command line.
cbentejac
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to make the imageProcessing exec self sufficient for vignetting and geometry correction, the capability to manage Adobe LCP files has been duplicated from the cameraInit exec. As a consequence a code factorization between these two execs has been done. In addition, support of chromatic aberration correction using LCP model has been enabled.
In relation with Meshroom PR alicevision/Meshroom#2042
Features list
Implementation remarks
The getSensorSize method return a non null error code if the sensor size cannot be computed of if it is computed with some uncertainty. This is needed for statistics generation on the read image set by the cameraInit exec. Because this method is used in a parallelized loop within cameraInit, verbosity can be disabled.
A pointer instead of a reference is used in the interface of getViewIntrinsic for the LensParam parameter to make it optional.