add dso module #24

monadbobo · 2012-07-20T07:16:41Z

add dso module

…hub.com/taobao/tengine/pull/1). 2 refactor some code.

add test scripts for dso module.

zls0424 · 2012-07-24T16:22:28Z

src/core/ngx_dso_module.c

+                   || (path->len == old_dl_m[i].path.len
+                      && ngx_strncmp(path->data, old_dl_m[i].path.data, old_dl_m[i].path.len) == 0))
+                {
+                    return NGX_DECLINED;


如果更改了动态模块的代码, 期望通过reload来生效, 这里是否会导致总是使用旧的代码?

这里是有意这么做的，如果更换了so文件，那么需要重启nginx。
原因是这样子的：
reload的时候，我无法卸载老的已经加载的dso模块，因为linux下dloepn打开都是有引用计数的。而不卸载老的加载的模块，就无法强制加载新的dso模块。
不过我确实应该文档里面注明的，明天我会修改下文档。
谢谢！

zls0424 · 2012-07-24T16:42:42Z

看了一下 diff 有几点疑问, 不知是否存在 ~

如果升级了 dso module 的代码, 能否通过 reload 来使新的 module 生效 (加载新的module) ?
如果想禁用某 dso module, 在配置里注掉 dso_load, reload 能否得到期望效果?
dso module 直接加载到全局的 ngx_modules 是有风险的, 如果新增加了dso_load 然后 reload 失败, ngx_modules 本身会被污染, 其他module的ctx_index等也可能会被改写, 之后如果有worker core了, master fork 出新的 worker, 取各 module conf 的时候可能是错的

monadbobo · 2012-07-24T16:56:49Z

1 如果更改了so，那么需要重启nginx才能生效。
2 这个也可以得到期望效果。
3 我们不支持so变化后的reload，因此这个不会成为问题。

谢谢。

zls0424 · 2012-07-25T06:06:23Z

src/core/ngx_dso_module.c

+        }
+    } else {
+        if (dcf->path.data[0] != '/') {
+            return NGX_ERROR;


在解析 dso_path 命令的时候没有要求必须是绝对路径, 这里缺少提示信息, -t fail 后用户不知道什么情况

zls0424 · 2012-07-25T06:21:26Z

感觉这样比较伤
这版代码里没看到相关的操作
这个不是指 dso 变化后的 reload, 比如新增了一条 dso 指令, 想 reload 生效的时候因为其他地方配置(比如某个跟 dso 无关的指令), 写错了导致失败了, 就会有这种情况

2 modify the directives of dso. 3 fix some bug.

monadbobo · 2012-07-31T03:57:33Z

1 不支持reload加载修改的dso模块原因是这样子的，如果你要重新加载新的dso，那么你必须dlclose老的handle，而如果你dlclose老的handle的话，当新的so加载失败的时候，此时就回不去原来的状态了。

2 剩下的两个问题，我这个新版本已经解决了。

谢谢！

fixed test-nginx with new dso module

zls0424 · 2012-08-09T07:52:41Z

src/core/ngx_dso_module.c

+
+    if (cycle != ngx_cycle) {
+
+        if (cycle->old_cycle->conf_ctx) {


应该是清理 cycle ?

2 fix bug of dso cleanup

2 modify load directives.

zhuzhaoyuan · 2012-09-05T12:23:22Z

src/core/ngx_dso_module.c

+static char *
+ngx_dso_stub(ngx_conf_t *cf, ngx_command_t *cmd, void *conf)
+{
+    ngx_str_t           *value, *module_name;


module_name -> module

zhuzhaoyuan · 2012-09-05T12:38:37Z

auto/make

+    if [ $NGX_DSO != YES ]; then
+    cat << END
+
+you should enable the dso module, if you want to use a dynamic loaded module.


dynamic -> dynamically

you should enable dso, if you ...

zhuzhaoyuan · 2012-09-05T13:59:18Z

auto/options

-HTTP_STUB_STATUS=NO
+HTTP_STUB_STATUS=YES
+
+#shared module


shared modules

yaoweibin · 2012-09-05T14:52:14Z

It looks good to me.

zhuzhaoyuan · 2012-09-05T15:00:25Z

It looks good to me.

monadbobo · 2012-09-05T15:06:38Z

will commit a new pull request.

monadbobo and others added 14 commits May 31, 2012 19:31

1 fix bugs of the limit_req module(please read this issue https://git…

402952f

…hub.com/taobao/tengine/pull/1). 2 refactor some code.

add limit_req module(enhanced) test case.

efe6f85

fixed code style.

361f599

fix compile warning.

ab9e717

Merge remote-tracking branch 'upstream/master' into upstream

5e52981

add Dynamic Shared Object(dso) module.

36f9fe1

add some configure help message.

2c8dca0

add dso test scripts

9be9564

Merge remote-tracking branch 'origin/dso' into dso

9610c45

Merge pull request #1 from yaoweibin/dso

84b3648

add test scripts for dso module.

Merge remote-tracking branch 'upstream/master' into tengine-dso

cfa9521

Merge branch 'dso' of github.com:monadbobo/tengine into tengine-dso

935bb19

1 modify some warn message.

195c6ac

add chinese doc of dso.

a061068

zls0424 reviewed Jul 24, 2012
View reviewed changes

zls0424 reviewed Jul 25, 2012
View reviewed changes

diaoliang and others added 2 commits July 27, 2012 17:19

1 modify the name of compiled dso module name.

85dcf9a

1 modify the name of dso module chinese doc.

12fc82b

2 modify the directives of dso. 3 fix some bug.

yaoweibin and others added 4 commits August 6, 2012 15:44

fixed test-nginx with new dso module

6da5567

Merge pull request #2 from yaoweibin/dso

ec6a5fc

fixed test-nginx with new dso module

to make right for compute of the flag_postion.

1f2258d

Merge branch 'dso' of github.com:monadbobo/tengine into dso

70c67b8

zls0424 reviewed Aug 9, 2012
View reviewed changes

src/core/ngx_dso_module.c

if (cycle != ngx_cycle) {

if (cycle->old_cycle->conf_ctx) {

Copy link

Contributor

zls0424 Aug 9, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是清理 cycle ?

monadbobo added 3 commits August 9, 2012 16:23

1 fix some code style

78ad1d8

2 fix bug of dso cleanup

1 modify help message of configure.

a46cad0

2 modify load directives.

update doc of dso module.

871b459

zhuzhaoyuan reviewed Sep 5, 2012
View reviewed changes

fix bug for duplicate load.

8b1e249

zhuzhaoyuan reviewed Sep 5, 2012
View reviewed changes

fix some code style

4efe343

zhuzhaoyuan reviewed Sep 5, 2012
View reviewed changes

auto/options

HTTP_STUB_STATUS=NO

HTTP_STUB_STATUS=YES

#shared module

Copy link

Member

zhuzhaoyuan Sep 5, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shared modules

monadbobo added 3 commits September 5, 2012 22:10

modify comment

a62ae88

fix bug for reload.

f81ecb2

fix code style.

e167210

monadbobo closed this Sep 5, 2012

ShahabKhalid mentioned this pull request Oct 1, 2020

Private IP Disclosure via hostname On Error Page #1494

Open

This was referenced Jan 26, 2024

tengine+xquic+tongsuo+QAT性能无提升 #1914

Open

[Bug]: xquic无法支持babaSSL的async_job（协程）导致QAT加速失效 alibaba/xquic#405

Open

fitch2015 mentioned this pull request Aug 5, 2024

dtls集成，nginx发生崩溃 #1951

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add dso module #24

add dso module #24

monadbobo commented Jul 20, 2012

zls0424 Jul 24, 2012

monadbobo Jul 24, 2012

zls0424 commented Jul 24, 2012

monadbobo commented Jul 24, 2012

zls0424 Jul 25, 2012

zls0424 commented Jul 25, 2012

monadbobo commented Jul 31, 2012

zls0424 Aug 9, 2012

zhuzhaoyuan Sep 5, 2012

zhuzhaoyuan Sep 5, 2012

zhuzhaoyuan Sep 5, 2012

zhuzhaoyuan Sep 5, 2012

yaoweibin commented Sep 5, 2012

zhuzhaoyuan commented Sep 5, 2012

monadbobo commented Sep 5, 2012

add dso module #24

add dso module #24

Conversation

monadbobo commented Jul 20, 2012

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zls0424 commented Jul 24, 2012

monadbobo commented Jul 24, 2012

Choose a reason for hiding this comment

zls0424 commented Jul 25, 2012

monadbobo commented Jul 31, 2012

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shared modules

yaoweibin commented Sep 5, 2012

zhuzhaoyuan commented Sep 5, 2012

monadbobo commented Sep 5, 2012