Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed bugs of the limit_req module #1

Closed
wants to merge 1 commit into from
Closed

fixed bugs of the limit_req module #1

wants to merge 1 commit into from

Conversation

zhuzhaoyuan
Copy link
Member

  • "limit_req zone=one;" was incorrectly disallowed
  • "limit_req on;" was allowed
  • the value of "burst" could not be zero

@zhuzhaoyuan
fixed bugs of limit_req:
2449804 
* "limit_req zone=one;" was incorrectly disallowed
* "limit_req on;" was allowed
* the value of "burst" could not be zero
@ghost ghost assigned monadbobo May 26, 2012
monadbobo
monadbobo reviewed May 30, 2012
View reviewed changes
src/http/modules/ngx_http_limit_req_module.c
@@ -1004,7 +1007,7 @@ static char *ngx_http_limit_req_whitelist(ngx_conf_t *cf, ngx_command_t *cmd,
if (ngx_strncmp(value[i].data, "burst=", 6) == 0) {

burst = ngx_atoi(value[i].data + 6, value[i].len - 6);
if (burst <= 0) {
if (burst == NGX_ERROR) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

burst must not be zero.

@zhuzhaoyuan
Copy link
Member Author

I don't understand, is it the default value of zero?

@monadbobo
Copy link
Member

if burst is zero, and then burst value is invalid.

@monadbobo
Copy link
Member

I will fix it later.

@monadbobo monadbobo closed this May 31, 2012
yaoweibin referenced this pull request in yaoweibin/tengine Aug 6, 2012
@monadbobo
Merge pull request #1 from yaoweibin/dso
84b3648 
add test scripts for dso module.
@yaoweibin yaoweibin mentioned this pull request Sep 19, 2012
Closed
dinic added a commit that referenced this pull request Mar 19, 2013
@dinic
Merge pull request #1 from yaoweibin/session_sticky
a0a7b5b 
updated docs for session sticky module
@alpha2z alpha2z mentioned this pull request Feb 9, 2015
Closed
@duncking duncking mentioned this pull request Nov 29, 2016
Closed
chobits pushed a commit that referenced this pull request Jan 29, 2019
@wangfakang
Merge pull request #1 from alibaba/master
c1d09d0 
sync master
@sunaihui sunaihui mentioned this pull request Apr 10, 2019
Closed
@CorefLava CorefLava mentioned this pull request May 30, 2019
Closed
@wgy-home wgy-home mentioned this pull request Jun 12, 2019
Closed
@xmlybob xmlybob mentioned this pull request Jun 26, 2019
Open
@johnripperdec johnripperdec mentioned this pull request Jul 18, 2019
Closed
@carlvine500 carlvine500 mentioned this pull request Mar 23, 2020
Open
mrpre pushed a commit that referenced this pull request Jun 12, 2020
@dkrutsko
Merge pull request #1 from StackAdapt/dave/prometheus
696ebf0
@adleader adleader mentioned this pull request Sep 15, 2022
Open
@devhaozi devhaozi mentioned this pull request Apr 10, 2023
Closed
@foxriver1025 foxriver1025 mentioned this pull request Jun 21, 2023
Closed
lianglli added a commit that referenced this pull request Jul 20, 2023
@lianglli
Merge pull request #1 from lianglli/tengine-3.0.0-readme
0226c94 
Readme: add tengine logo
@yourchanges yourchanges mentioned this pull request Oct 13, 2023
Closed
This was referenced Jan 26, 2024
Open
Open
@shenxf1205 shenxf1205 mentioned this pull request Apr 2, 2024
Open
This was referenced Apr 16, 2024
Open
Closed
@fitch2015 fitch2015 mentioned this pull request Aug 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@monadbobo monadbobo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhuzhaoyuan @monadbobo