New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new features: add distributed scheduling support. #3732

Merged

chickenlj merged 5 commits into alibaba:2023.x from yaohuitc:2023.x

May 31, 2024

Contributor

yaohuitc commented May 13, 2024

new features: add distributed scheduling support.


          new features: add distributed scheduling support.

e5d2757

chickenlj approved these changes

View reviewed changes

Collaborator

chickenlj left a comment

LGTM.

yuluo-yx reviewed

View reviewed changes

spring-cloud-alibaba-examples/pom.xml Show resolved Hide resolved

yuluo-yx reviewed

View reviewed changes

spring-cloud-alibaba-examples/spring-cloud-scheduling-example/pom.xml Outdated Show resolved Hide resolved

yuluo-yx reviewed

View reviewed changes

...cheduling-example/src/main/java/com/alibaba/cloud/examples/schedule/ScheduleApplication.java Outdated Show resolved Hide resolved

yuluo-yx reviewed

View reviewed changes

...loud-scheduling-example/src/main/java/com/alibaba/cloud/examples/schedule/job/SimpleJob.java Outdated Show resolved Hide resolved

...baba-examples/spring-cloud-scheduling-example/src/main/resources/application-schedulerx.yaml Outdated Show resolved Hide resolved

...g-cloud-alibaba-examples/spring-cloud-scheduling-example/src/main/resources/application.yaml Outdated Show resolved Hide resolved

...schedulerx/src/main/java/com/alibaba/cloud/scheduling/schedulerx/service/JobSyncService.java Outdated Show resolved Hide resolved

...schedulerx/src/main/java/com/alibaba/cloud/scheduling/schedulerx/service/JobSyncService.java Outdated Show resolved Hide resolved

...schedulerx/src/main/java/com/alibaba/cloud/scheduling/schedulerx/service/JobSyncService.java Outdated Show resolved Hide resolved

...ba-schedulerx/src/main/java/com/alibaba/cloud/scheduling/shedlock/ShedLockAutoConfigure.java Show resolved Hide resolved

...tarters/spring-cloud-starter-alibaba-schedulerx/src/main/resources/META-INF/spring.factories Outdated Show resolved Hide resolved

...n/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports Outdated Show resolved Hide resolved

.../spring-cloud-starter-alibaba-schedulerx/src/main/resources/shedlock/schema/schema-mysql.sql Outdated Show resolved Hide resolved

yuluo-yx added kind/enhancement area/scheduling labels


          new features: add distributed scheduling support.（resolve conversation）

df98d8d

yaohuitc commented

View reviewed changes

Contributor Author

yaohuitc left a comment

done

.../spring-cloud-starter-alibaba-schedulerx/src/main/resources/shedlock/schema/schema-mysql.sql Outdated Show resolved Hide resolved

spring-cloud-alibaba-examples/spring-cloud-scheduling-example/pom.xml Outdated Show resolved Hide resolved

...cheduling-example/src/main/java/com/alibaba/cloud/examples/schedule/ScheduleApplication.java Outdated Show resolved Hide resolved

...baba-examples/spring-cloud-scheduling-example/src/main/resources/application-schedulerx.yaml Outdated Show resolved Hide resolved

...g-cloud-alibaba-examples/spring-cloud-scheduling-example/src/main/resources/application.yaml Outdated Show resolved Hide resolved

...schedulerx/src/main/java/com/alibaba/cloud/scheduling/schedulerx/service/JobSyncService.java Outdated Show resolved Hide resolved

...ba-schedulerx/src/main/java/com/alibaba/cloud/scheduling/shedlock/ShedLockAutoConfigure.java Show resolved Hide resolved

...tarters/spring-cloud-starter-alibaba-schedulerx/src/main/resources/META-INF/spring.factories Outdated Show resolved Hide resolved

...n/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports Outdated Show resolved Hide resolved

...loud-scheduling-example/src/main/java/com/alibaba/cloud/examples/schedule/job/SimpleJob.java Outdated Show resolved Hide resolved

yaohuitc requested a review from yuluo-yx

May 16, 2024 07:14

Collaborator

yuluo-yx commented May 16, 2024

hi @yaohuitc pls fix ci, before commit, you can run mvn clean install -Dmaven.test.sip=true to check code style. or run mvn clean install to sca.

yuluo-yx assigned yaohuitc


          new features: add distributed scheduling support.（fix）

387c014

Collaborator

yuluo-yx commented May 16, 2024 •

edited

Loading

@yaohuitc Can you write readme.md files? I don't konw how to config application.yml and other configuration.I cann't run example on my local machine.

yuluo-yx reviewed

View reviewed changes

Collaborator

yuluo-yx left a comment

Add some comment.

spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-schedulerx/pom.xml Outdated Show resolved Hide resolved

yaohuitc closed this

yaohuitc reopened this

Contributor Author

yaohuitc commented May 17, 2024

@yaohuitc Can you write readme.md files? I don't konw how to config application.yml and other configuration.I cann't run example on my local machine.

can you share some error information when you're running the example

Collaborator

yuluo-yx commented May 17, 2024 •

edited

Loading

Public Key Retrieval is not allowed

add allowPublicKeyRetrieval=true

java.sql.SQLException: Access denied for user 'root'@'localhost' (using password: YES)
java.sql.SQLSyntaxErrorException: Unknown database 'testdb'

Since there is no readme documentation, I don't know what to configure or change, and there is no sql script in the example

Contributor Author

yaohuitc commented May 17, 2024

Public Key Retrieval is not allowed

add allowPublicKeyRetrieval=true
java.sql.SQLException: Access denied for user 'root'@'localhost' (using password: YES)
java.sql.SQLSyntaxErrorException: Unknown database 'testdb'
Since there is no readme documentation, I don't know what to configure or change, and there is no sql script in the example

OK, 👌


          add README for spring-cloud-scheduling-example

e578a07

yuluo-yx approved these changes

View reviewed changes

Collaborator

yuluo-yx left a comment

LGTM, tks @yaohuitc

Collaborator

yuluo-yx commented May 20, 2024

pls resolve conflicts, We will discuss this at the next weekly meeting and merge afterward.


          Merge branch '2023.x' of https://github.com/alibaba/spring-cloud-alibaba

eda5a1c

 into 2023.x

� Conflicts:
�	spring-cloud-alibaba-examples/pom.xml

chickenlj merged commit 79bca1e into alibaba:2023.x

4 checks passed

This was referenced May 31, 2024

new features: add distributed scheduling support. #3725

Merged

new features: add distributed scheduling support. #3726

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/scheduling kind/enhancement