fix: Nacos integration with SpringBootAdmin.(2022.x) #3318
Conversation
…binations compatible with spring cloud gateway, spring boot admin, and others
|
LGTM |
| @@ -355,5 +355,6 @@ spring.cloud.nacos.discovery.ip-type=IPv6 | |||
| |接入点|`spring.cloud.nacos.discovery.endpoint`||地域的某个服务的入口域名，通过此域名可以动态地拿到服务端地址 | |||
| |是否集成LoadBalancer|`spring.cloud.loadbalancer.nacos.enabled`|`false`| | |||
| |是否开启Nacos Watch|`spring.cloud.nacos.discovery.watch.enabled`|`false`|可以设置成 true 来开启 watch | |||
| |是否开启Nacos Discovery HeartBeat|`spring.cloud.nacos.discovery.heart-beat.enabled`|`false`|可以设置成 true 来开启 heart beat | |||
There was a problem hiding this comment.
heartbeat is a word. I think use spring.cloud.nacos.discovery.heartbeat.enabled is better.
There was a problem hiding this comment.
heartbeat is a word. I think use
spring.cloud.nacos.discovery.heartbeat.enabledis better.
I saw that other configurations are also named like this, so I referred to them.
e.g. spring.cloud.nacos.discovery.heart-beat-timeout
Of course, I strongly support replacing it with heartbeat.Do I need to change to heartbeat?
There was a problem hiding this comment.
There was a problem hiding this comment.
spring.cloud.nacos.discovery.heart-beat-timeout
I didn't notice it before, so let's keep it consistent
|
所以在nacos整合spring boot admin的时候我要进行什么配置才能实现SBA的上下线监听？我使用spring.cloud.nacos.discovery.heart-beat.enabled=true似乎不起作用。 |
sba 针对服务的上下线监听实际上是通过 actuator health 接口来判断的，
如果上面2个步骤确认没有问题，可以单独提交一个 issue 详细说明一下你遇到的问题 |
Describe what this PR does / why we need it
Refactor GatewayLocatorHeartBeatPublisher to enable friendly subscription to HeartBeat events in addition to the gateway
Does this pull request fix one issue?
Refer #3258
Describe how you did it
spring.cloud.nacos.discovery.heart-beat.enabledto enableNacosDiscoveryHeartBeatPublisher, default isfalse.