fix: Nacos integration with SpringBootAdmin.(2.2.x) #3308
Conversation
…binations compatible with spring cloud gateway, spring boot admin, and others
|
@steverao @ruansheng8 May I ask when this PR can be reviewed? this pr is to solve the heartbeat problem for 2.2.x |
| @@ -90,6 +90,11 @@ | |||
| <artifactId>spring-cloud-starter-openfeign</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
单元测试的时候，这个模块总是测试不通过，抛异常zuul的类找不到，于是我就添加了spring-cloud-netflix-zuul用于测试，测试就通过了
There was a problem hiding this comment.
具体可以参看一下昨天执行失败的那个集成测试action，是和此次pr无关的xds-adapter模块测试没通过
https://github.com/alibaba/spring-cloud-alibaba/actions/runs/5016091380
There was a problem hiding this comment.
具体可以参看一下昨天执行失败的那个集成测试action，是和此次pr无关的xds-adapter模块测试没通过 https://github.com/alibaba/spring-cloud-alibaba/actions/runs/5016091380
我看了一下这个问题是这次修复新引入的，具体是NacosDiscoveryHeartBeatConfiguration类中的@AutoConfigureAfter注解引发的，需要解决一下，否则后边其他人引入Nacos相关依赖都需要手动添加Zuul依赖。
There was a problem hiding this comment.
具体可以参看一下昨天执行失败的那个集成测试action，是和此次pr无关的xds-adapter模块测试没通过 https://github.com/alibaba/spring-cloud-alibaba/actions/runs/5016091380
我看了一下这个问题是这次修复新引入的，具体是
NacosDiscoveryHeartBeatConfiguration类中的@AutoConfigureAfter注解引发的，需要解决一下，否则后边其他人引入Nacos相关依赖都需要手动添加Zuul依赖。
感谢提醒，通过仔细阅读代码我明白问题在哪了。正如您所说，我尽快解决这个问题
There was a problem hiding this comment.
LGTM, thanks @zhangbinhub Please add my dingtalk's account: steverao2021
Describe what this PR does / why we need it
Refactor GatewayLocatorHeartBeatPublisher to enable friendly subscription to HeartBeat events in addition to the gateway
Does this pull request fix one issue?
Refer #3258
Describe how you did it
spring.cloud.nacos.discovery.heart-beat.enabledto enableNacosDiscoveryHeartBeatPublisher, default isfalse.