Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: nacos example method naming typo #3301

Merged
merged 1 commit into from
May 8, 2023
Merged

Fix: nacos example method naming typo #3301

merged 1 commit into from
May 8, 2023

Conversation

haigeek
Copy link
Contributor

@haigeek haigeek commented May 6, 2023

com.alibaba.cloud.examples.example#remoteConfig maybe a typo,update the method name from remoteConfig to removeConfig

steverao
steverao approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@steverao steverao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @haigeek Please check whether there is same problem in branch of 2.2.x and 2021.x, if yes, please create same PR to them, because they are also our main branchs.

This was referenced May 8, 2023
Merged
Merged
@haigeek
Copy link
Contributor Author

haigeek commented May 8, 2023

@steverao ok, please check the PR #3304 #3305

@ruansheng8 ruansheng8 merged commit c1a20e1 into alibaba:2022.x May 8, 2023
@ruansheng8
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steverao steverao steverao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haigeek @ruansheng8 @steverao