Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sidecar-example in 2022.x #3267

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Fix: sidecar-example in 2022.x #3267

merged 2 commits into from
Apr 19, 2023

Conversation

yuluo-yx
Copy link
Collaborator

fix #3257 in 2022.x

@@ -35,6 +35,11 @@
<artifactId>spring-cloud-starter-alibaba-nacos-discovery</artifactId>
</dependency>

<dependency>
<groupId>org.springframework.cloud</groupId>
<artifactId>spring-cloud-loadbalancer</artifactId>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't use spring-cloud-starter-loadbalancer here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

Copy link
Collaborator

@steverao steverao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @yuluo-yx

@steverao steverao merged commit 1fa5b9d into alibaba:2022.x Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spring-cloud-alibaba-sidecar-nacos-example test failed in 2022.x
2 participants