Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fallback support factoryBean #3135

Merged
merged 6 commits into from
Feb 18, 2023
Merged

fallback support factoryBean #3135

merged 6 commits into from
Feb 18, 2023

Conversation

min1854
Copy link
Contributor

@min1854 min1854 commented Feb 3, 2023

Describe what this PR does / why we need it

fallback support factoryBean

Does this pull request fix one issue?

spring-cloud/spring-cloud-openfeign#822

Describe how you did it

Describe how to verify it

junit test

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ruansheng8
Copy link
Collaborator

The CheckStyle plugin is temporarily unavailable on the 2022.x branch. Please copy the PR code to the 2021.x branch and then run mvn clean validate to check the code. For example, each file should end with a blank line.
See https://github.com/spring-cloud/spring-cloud-build#checkstyle

image

@ruansheng8 ruansheng8 self-requested a review February 16, 2023 13:12
steverao
steverao approved these changes Feb 18, 2023
View reviewed changes
Copy link
Collaborator

@steverao steverao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check whether need to create a same PR to branch of 2021.x and 2.2.x. They are also main branch of community.

@steverao steverao merged commit f053317 into alibaba:2022.x Feb 18, 2023
@ruansheng8 ruansheng8 added the waiting for sync waiting for sync to other main branchs label Feb 18, 2023
@min1854
Copy link
Contributor Author

min1854 commented Feb 20, 2023

Please check whether need to create a same PR to branch of 2021.x and 2.2.x. They are also main branch of community.

Does it mean me? If so, how should I do this, create two pull requests?

@ruansheng8
Copy link
Collaborator

Please check whether need to create a same PR to branch of 2021.x and 2.2.x. They are also main branch of community.

Does it mean me? If so, how should I do this, create two pull requests?

Yes , the changes in this PR are applicable to both the 2021.x and 2.2.x branches, please submit two separate PR to merge them into 2021.x and 2.2.x, respectively.

This was referenced Feb 20, 2023
Merged
Merged
@ruansheng8 ruansheng8 removed the waiting for sync waiting for sync to other main branchs label Feb 20, 2023
@chickenlj chickenlj mentioned this pull request Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruansheng8 ruansheng8 ruansheng8 approved these changes

@steverao steverao steverao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@min1854 @CLAassistant @ruansheng8 @steverao