Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests and doc about governance module #2919

Merged
merged 11 commits into from
Nov 23, 2022

Conversation

123liuziming
Copy link
Collaborator

Describe what this PR does / why we need it

add some unit tests

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@steverao
Copy link
Collaborator

I saw there are some Chinese pictures in English docs. You need to modify them. BTW, we recommend to give a file name to picture. Other before pictures will be modified later.

@123liuziming 123liuziming changed the title 2.2.x governance Unit Tests and doc about governance module Nov 22, 2022
@123liuziming
Copy link
Collaborator Author

I saw there are some Chinese pictures in English docs. You need to modify them. BTW, we recommend to give a file name to picture. Other before pictures will be modified later.

I 've modified them

@steverao steverao merged commit 74665ab into alibaba:2.2.x-governance Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants