Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NacosWatch and support zuul in 2.2.x #2904

Merged
merged 5 commits into from
Nov 16, 2022

Conversation

ruansheng8
Copy link
Collaborator

Describe what this PR does / why we need it

Refactor NacosWatch

Does this pull request fix one issue?

Refer #2868

Describe how you did it

1. NacosWatch is no longer enabled by default .

Using spring.cloud.nacos.discovery.watch.enabled=true to enabled it.

2. NacosWatch#heartBeat migrate to GatewayLocatorHeartBeatPublisher

GatewayLocatorHeartBeatPublisher is disabled by default , It will enabled if spring.cloud.gateway.discovery.locator.enabled is true or using @EnableZuulProxy

Copy link
Collaborator

@steverao steverao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify the setting below:

{
      "name": "spring.cloud.nacos.discovery.watch.enabled",
      "type": "java.lang.Boolean",
      "defaultValue": "true",
      "description": "enable nacos discovery watch or not ."
}

@ruansheng8
Copy link
Collaborator Author

Please modify the setting below:

{
      "name": "spring.cloud.nacos.discovery.watch.enabled",
      "type": "java.lang.Boolean",
      "defaultValue": "true",
      "description": "enable nacos discovery watch or not ."
}

Ok , I also updated the related doc , and i will I create a new PR to 2021.x branch.

@yuhuangbin yuhuangbin merged commit eb34238 into alibaba:2.2.x Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants