Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 2698: resolve errors in generating javadocs by mvn install #2781

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

pandaapo
Copy link
Contributor

@pandaapo pandaapo commented Sep 16, 2022

Describe what this PR does / why we need it

Fix errors that are reported when generating javadocs by mvn install in branch 2021.x.

Does this pull request fix one issue?

Fixes #2698 in branch 2021.x

Describe how you did it

Describe how to verify it

run mvn install, mvn javadoc:javadoc(build faster) or mvn javadoc:javadoc-no-fork(build faster)

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Sep 16, 2022

CLA assistant check
All committers have signed the CLA.

@steverao
Copy link
Collaborator

LGTM, please create a same PR to branch of 2.2.x, it's also our main branch.

@pandaapo
Copy link
Contributor Author

LGTM, please create a same PR to branch of 2.2.x, it's also our main branch.

I'm OK. But I found the open PR 2776 that already dealed with this issue in branch of 2.2.x. Does it matter if I create PR too?

@steverao
Copy link
Collaborator

LGTM, please create a same PR to branch of 2.2.x, it's also our main branch.

I'm OK. But I found the open PR 2776 that already dealed with this issue in branch of 2.2.x. Does it matter if I create PR too?

There are some wrong, it didn't solve and you can create a PR to fix, such as the wrong package name com.alibaba.cloud.examples.orderly.

@steverao steverao merged commit ed26351 into alibaba:2021.x Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants