refactor RocketMQProduceFactory: reuse producer #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorieee
reviewed
Aug 8, 2022
...va/com/alibaba/cloud/stream/binder/rocketmq/integration/outbound/RocketMQProduceFactory.java
Outdated
Show resolved
Hide resolved
...va/com/alibaba/cloud/stream/binder/rocketmq/integration/outbound/RocketMQProduceFactory.java
Outdated
Show resolved
Hide resolved
...va/com/alibaba/cloud/stream/binder/rocketmq/integration/outbound/RocketMQProduceFactory.java
Outdated
Show resolved
Hide resolved
...va/com/alibaba/cloud/stream/binder/rocketmq/integration/outbound/RocketMQProduceFactory.java
Show resolved
Hide resolved
...va/com/alibaba/cloud/stream/binder/rocketmq/integration/outbound/RocketMQProduceFactory.java
Outdated
Show resolved
Hide resolved
...va/com/alibaba/cloud/stream/binder/rocketmq/integration/outbound/RocketMQProduceFactory.java
Show resolved
Hide resolved
|
Maybe Spring cloud stream had cache producer, we don't need to cache producer in spring cloud alibaba. |
2. Don't reuse TransactionMQProducer 3. Add `sendCallBack` to key
steverao
reviewed
Aug 23, 2022
...va/com/alibaba/cloud/stream/binder/rocketmq/integration/outbound/RocketMQProduceFactory.java
Outdated
Show resolved
Hide resolved
|
@steverao @zkzlx @yuhuangbin This PR may be reviewed and merged |
steverao
approved these changes
Nov 15, 2022
yuhuangbin
approved these changes
Nov 16, 2022
|
Don't forget to create a same PR to branch of 2021.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Refactor RocketMQProduceFactory: reuse producer
Does this pull request fix one issue?
Describe how you did it
private static Map<String, DefaultMQProducer> producers = new HashMap<>();to store producers in the factory.Describe how to verify it
Create several output bindings, and the producer will be reused.
Special notes for reviews