Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some rocketmq examples #2505

Merged
merged 10 commits into from
May 11, 2022
Merged

Some rocketmq examples #2505

merged 10 commits into from
May 11, 2022

Conversation

Sorieee
Copy link
Contributor

@Sorieee Sorieee commented Apr 9, 2022 •
edited
Loading

Describe what this PR does / why we need it

Parts of #2481 works.

Does this pull request fix one issue?

Some examples of rocketmq stream:

  • broadcast
  • delay
  • orderly
  • sql
    Will imporve docs and write some other example latter.

Describe how you did it

Describe how to verify it

Manual test

Special notes for reviews

@Sorieee Sorieee changed the title 2021.x.sorie.rkmq.example Some rocketmq examples Apr 9, 2022
@Sorieee Sorieee force-pushed the 2021.x.sorie.rkmq.example branch from 48cd50d to 74f1df7 Compare April 9, 2022 08:28
@steverao
Copy link
Collaborator

Add some readme documentations please!

@Sorieee
Copy link
Contributor Author

Sorieee commented Apr 10, 2022

Add some readme documentations please!

Will add readme doc today(4.10) or tomorrow(4.11).

@steverao
Copy link
Collaborator

I found a problem about your examples, i think the feature example provided now isn't a normal using method in daily Spring Cloud application, maybe we should provide a standard using method that users can use directly. Such as using @Autowired to create a MessageProvider, and users can use it to produce message.

@Sorieee
Copy link
Contributor Author

Sorieee commented Apr 10, 2022

I found a problem about your examples, i think the feature example provided now isn't a normal using method in daily Spring Cloud application, maybe we should provide a standard using method that users can use directly. Such as using @Autowired to create a MessageProvider, and users can use it to produce message.

Got it.

@Sorieee
Copy link
Contributor Author

Sorieee commented Apr 11, 2022 •
edited
Loading

Add some readme documentations please!

Will add readme doc today(4.10) or tomorrow(4.11).

Worked overtime today, may finish this week.

@Sorieee
Copy link
Contributor Author

Sorieee commented Apr 11, 2022

I found a problem about your examples, i think the feature example provided now isn't a normal using method in daily Spring Cloud application, maybe we should provide a standard using method that users can use directly. Such as using @Autowired to create a MessageProvider, and users can use it to produce message.

StreamBridge has been used instead of functional producder.

@Sorieee Sorieee marked this pull request as draft April 12, 2022 06:44
@Sorieee
Copy link
Contributor Author

Sorieee commented Apr 14, 2022

Reopen for discussion.

@Sorieee Sorieee marked this pull request as ready for review April 14, 2022 00:51
@Sorieee
Copy link
Contributor Author

Sorieee commented Apr 17, 2022

Add some readme documentations please!
Done.

@Sorieee
Copy link
Contributor Author

Sorieee commented Apr 17, 2022

Ready to review.
This pr is not including Transactional example, will add Transactional exmaple next week(maybe 4.24).
Also not including rocketmq docs in spring-cloud-alibaba-docs, will improve it alter(maybe before 5.5）

@steverao
Copy link
Collaborator

steverao commented May 9, 2022

Please pay attention to checkstyle check error in Integration Testing.

steverao
steverao reviewed May 10, 2022
View reviewed changes
...-example/src/main/java/com/alibaba/cloud/examples/delay/RocketMQDelayConsumeApplication.java Outdated
}

@Bean
public ApplicationRunner producerSchedule() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message can't be consumed in 3s later.

@Sorieee
remove timed message example from rocketmq examples.
6e92b5c 
Because it is not supported by rocketmq community version now.
@steverao steverao merged commit db3f4a8 into alibaba:2021.x May 11, 2022
@Sorieee Sorieee mentioned this pull request May 22, 2022
Merged
@Sorieee Sorieee mentioned this pull request May 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steverao steverao steverao left review comments

Assignees

@Sorieee Sorieee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sorieee @steverao