Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sentinel datasource init error in jacocoagent environment #2477

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Fix sentinel datasource init error in jacocoagent environment #2477

merged 3 commits into from
Apr 7, 2022

Conversation

hnyyghk
Copy link
Contributor

@hnyyghk hnyyghk commented Mar 23, 2022

Describe what this PR does / why we need it

Fix sentinel datasource init error in jacocoagent environment

Does this pull request fix one issue?

Fixes #2476

Describe how you did it

  1. add isSynthetic check
  2. wrote some unit test for DataSourcePropertiesConfiguration and SentinelDataSourceHandler

Describe how to verify it

  1. download jacoco library files:https://www.eclemma.org/jacoco/
  2. run unit test with jacocoagent.jar, VM options like:
    -javaagent:D:\Users\Test\Desktop\jacoco-0.8.7\lib/jacocoagent.jar=includes=*,output=tcpserver,port=6271,address=127.0.0.1,append=true

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Mar 23, 2022

CLA assistant check
All committers have signed the CLA.

@DanielLiu1123 DanielLiu1123 added the area/sentinel spring cloud alibaba sentinel label Mar 28, 2022
@hnyyghk hnyyghk requested a review from DanielLiu1123 April 3, 2022 07:19
@DanielLiu1123
Copy link
Collaborator

You have code style problems. Please execute mvn clean compile and fix it.

@hnyyghk
Copy link
Contributor Author

hnyyghk commented Apr 5, 2022

code style problems is fixed

@DanielLiu1123 DanielLiu1123 merged commit 0ccaaf6 into alibaba:2021.x Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sentinel spring cloud alibaba sentinel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sentinel datasource init error in jacocoagent environment
3 participants