optimize: alibaba-seata: Transfer XID using feign.RequestInterceptor
#1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…seata-transmit-xid # Conflicts: # spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-seata/src/main/java/com/alibaba/cloud/seata/feign/SeataFeignObjectWrapper.java
llanc
approved these changes
Jun 3, 2021
|
为什么把seata的feign全部删掉，冲突的话指出具体冲突在哪里，解决冲突，这个删除的太多，具体单侧通过了吗 |
这些类的目的就两个：
原来的代码存在的问题：
两个类就能实现的功能，为什么要用10个类呢？是吧。 |
yuhuangbin
reviewed
Dec 20, 2022
...aba-seata/src/main/java/com/alibaba/cloud/seata/feign/SeataFeignClientAutoConfiguration.java
Outdated
Show resolved
Hide resolved
yuhuangbin
approved these changes
Dec 21, 2022
wangliang181230
added a commit
to wangliang181230/spring-cloud-alibaba
that referenced
this pull request
Dec 21, 2022
alibaba#1946) * optimize: alibaba-seata: Transfer XID using `feign.RequestInterceptor` * 移除多余的代码 * imports顺序调整。 * Feign.Builder的默认retryer修改为NEVER_RETRY。 * fix style * fix style * Update SeataFeignBuilderBeanPostProcessor.java * add static
This was referenced Dec 21, 2022
wangliang181230
added a commit
to wangliang181230/spring-cloud-alibaba
that referenced
this pull request
Feb 23, 2023
alibaba#1946) (alibaba#2993) * optimize: alibaba-seata: Transfer XID using `feign.RequestInterceptor` * 移除多余的代码 * imports顺序调整。 * Feign.Builder的默认retryer修改为NEVER_RETRY。 * fix style * fix style * Update SeataFeignBuilderBeanPostProcessor.java * add static
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
optimize: alibaba-seata: Transfer XID using
feign.RequestInterceptor解决的问题：
Feign.Builder feignHystrixBuilder(BeanFactory beanFactory);Does this pull request fix one issue?
Fixes #1307
Fixes #1377
Describe how you did it
NONE
Describe how to verify it
NONE
Special notes for reviews
NONE