-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE#6999] Solve the problem that Nacos client does not support logback overload log configuration #8229
[ISSUE#6999] Solve the problem that Nacos client does not support logback overload log configuration #8229
Conversation
…ation logback . issu… (alibaba#7596)" This reverts commit 7bb6cf2.
This reverts commit b5f7a69.
i found #7596 make some bug, i did not figure it out . I do not know what the bug is for this pr , Is NacosContextInitializer and NacosJorndan neccesarry ? more ut or more description could make it clear |
|
The role of these two classes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not rewrite registerSafeConfiguration
and informContextOfURLUsedForConfiguration
in NacosJoranConfigurator.java
?
client/src/main/java/com/alibaba/nacos/client/logging/logback/LogbackNacosLogging.java
Outdated
Show resolved
Hide resolved
|
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
for #6999
Brief changelog
Verifying this change
2.. When using logback overload function, Nacos SDK remote The log is printed normally, and the user log is overloaded normally
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.