[ISSUE #6970] Add rest api v2 in core module #7085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that CI can't pass. Can you check and fix it first? |
done |
|
Can we talk? Whatsapp!? |
|
Should we add |
Great idea, I have added annotations for these controllers. |
KomachiSion
reviewed
Nov 4, 2021
| @@ -60,6 +60,7 @@ | |||
| <module name="AbbreviationAsWordInName"> | |||
| <property name="ignoreFinal" value="false"/> | |||
| <property name="allowedAbbreviationLength" value="1"/> | |||
| <property name="allowedAbbreviations" value="VO"/> | |||
There was a problem hiding this comment.
Why change check style?
There was a problem hiding this comment.
Cause some domain object like DTO、VO cannot pass checkstyle, I add VO here
|
Good Day,
I'm sorry late reply i have problem in my internet connection and my
phone and also not enough memory. If i fix it or my contribute I can earn.
…On Thu, Nov 4, 2021, 10:02 AM 杨翊 SionYang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In style/NacosCheckStyle.xml
<#7085 (comment)>:
> @@ -60,6 +60,7 @@
<module name="AbbreviationAsWordInName">
<property name="ignoreFinal" value="false"/>
<property name="allowedAbbreviationLength" value="1"/>
+ <property name="allowedAbbreviations" value="VO"/>
Why change check style?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#7085 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWAV7XTUQ33ZAO54PGEWPZ3UKHST7ANCNFSM5GDMPW3Q>
.
|
|
What name changed?
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: jenny friel regala ***@***.***>
Sent: Thursday, November 4, 2021 1:23:30 PM
To: alibaba/nacos ***@***.***>
Subject: Re: [alibaba/nacos] [ISSUE #6970] Add rest api v2 in core module (#7085)
Good Day,
I'm sorry late reply i have problem in my internet connection and my phone and also not enough memory. If i fix it or my contribute I can earn.
On Thu, Nov 4, 2021, 10:02 AM 杨翊 SionYang ***@***.******@***.***>> wrote:
@KomachiSion commented on this pull request.
________________________________
In style/NacosCheckStyle.xml<#7085 (comment)>:
@@ -60,6 +60,7 @@
<module name="AbbreviationAsWordInName">
<property name="ignoreFinal" value="false"/>
<property name="allowedAbbreviationLength" value="1"/>
+ <property name="allowedAbbreviations" value="VO"/>
Why change check style?
―
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#7085 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWAV7XTUQ33ZAO54PGEWPZ3UKHST7ANCNFSM5GDMPW3Q>.
|
KomachiSion
approved these changes
Nov 10, 2021
|
Okay
…On Wed, Nov 10, 2021, 2:11 PM 杨翊 SionYang ***@***.***> wrote:
Merged #7085 <#7085> into develop.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#7085 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWAV7XQHTUPE77DQN553K6LULIEKPANCNFSM5GDMPW3Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
fixes #6970