replace lang3 in api #3126
replace lang3 in api #3126
Conversation
|
@KomachiSion Hello，可以帮忙看下为什么 Travis CI 失败了吗。 |
There was a problem hiding this comment.
There are one thing need to changed:
No need use this in method except the constructor, set and get method. Please remove them from all.
And other question:
If the Utils is totally copy from commons-lang3, Are there necessary to remove the dependency in Server? We may need a more discuss.
| @JsonIgnore | ||
| public Map<String, String> getCustomHeaders() { | ||
| if (StringUtils.isBlank(headers)) { | ||
| if (StringUtils.isBlank(this.headers)) { |
There was a problem hiding this comment.
No need use this for use except in constructor, set, get.
| for (String s : headers.split(Constants.NAMING_HTTP_HEADER_SPILIER)) { | ||
| String[] splits = s.split(":"); | ||
| final Map<String, String> headerMap = new HashMap<String, String>(16); | ||
| for (final String s : this.headers.split(Constants.NAMING_HTTP_HEADER_SPILIER)) { |
There was a problem hiding this comment.
No need use this for use except in constructor, set, get.
| @Override | ||
| public int hashCode() { | ||
| return Objects.hashCode(path, headers, expectedResponseCode); | ||
| return Objects.hashCode(this.path, this.headers, this.expectedResponseCode); |
There was a problem hiding this comment.
No need use this for use except in constructor, set, get.
| final Http other = (Http) obj; | ||
| if (!StringUtils.equals(this.type, other.getType())) { |
There was a problem hiding this comment.
No need use this for use except in constructor, set, get.
| return false; | ||
| } | ||
| return expectedResponseCode == other.getExpectedResponseCode(); | ||
| return this.expectedResponseCode == other.getExpectedResponseCode(); |
There was a problem hiding this comment.
No need use this for use except in constructor, set, get.
| */ | ||
| public static final int OVER_THRESHOLD = 503; | ||
|
|
||
| public static final int RESOURCE_NOT_FOUND = -404; |
There was a problem hiding this comment.
这个码是什么意思？
-404 吗，这个之前就已经存在了，是 @nkorange 添加的
KomachiSion
added
kind/refactor
dependencies
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
#3102
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.