Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #2810] don't send beat when standalone model #3047

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

horizonzy
Copy link
Collaborator

What is the purpose of the change

fix-#2810

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one code style problem.

@@ -484,10 +484,9 @@ public void run() {

public void sendBeat() throws IOException, InterruptedException {
RaftPeer local = peers.local();
if (local.state != RaftPeer.State.LEADER && !ApplicationUtils.getStandaloneMode()) {
if (ApplicationUtils.getStandaloneMode() || local.state != RaftPeer.State.LEADER){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be one blank between ) and { please

@KomachiSion KomachiSion added area/Naming kind/refactor kind/enhancement Category issues or prs related to enhancement. and removed status/invalid This doesn't seem right kind/refactor labels Jun 16, 2020
@KomachiSion KomachiSion added this to the 1.3.1 milestone Jun 16, 2020
@horizonzy horizonzy requested a review from KomachiSion June 16, 2020 15:26
@KomachiSion KomachiSion merged commit aea7dd6 into alibaba:develop Jun 17, 2020
@horizonzy horizonzy deleted the fix-2810 branch December 24, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Naming kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants