add comment

api/pom.xml

@@ -29,6 +29,7 @@
 
     <name>nacos-api ${project.version}</name>
     <url>https://nacos.io</url>
+    <description>Nacos api pom.xml file</description>
     <build>
         <plugins>
             <!--  reuse when you need to update grpc model  -->

auth/src/main/java/com/alibaba/nacos/auth/config/AuthConfigs.java

@@ -26,6 +26,8 @@
 import com.alibaba.nacos.common.utils.StringUtils;
 import com.alibaba.nacos.plugin.auth.constant.Constants;
 import com.alibaba.nacos.sys.env.EnvUtil;
+import com.alibaba.nacos.sys.module.ModuleState;
+import com.alibaba.nacos.sys.module.ModuleStateHolder;
 import com.alibaba.nacos.sys.utils.PropertiesUtil;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -179,6 +181,11 @@ public void onEvent(ServerConfigChangeEvent event) {
                     .getProperty(Constants.Auth.NACOS_CORE_AUTH_ENABLE_USER_AGENT_AUTH_WHITE, Boolean.class, false);
             nacosAuthSystemType = EnvUtil.getProperty(Constants.Auth.NACOS_CORE_AUTH_SYSTEM_TYPE, "");
             refreshPluginProperties();
+            ModuleStateHolder.getInstance().getModuleState(AuthModuleStateBuilder.AUTH_MODULE)
+                    .ifPresent(moduleState -> {
+                        ModuleState temp = new AuthModuleStateBuilder().build();
+                        moduleState.getStates().putAll(temp.getStates());
+                    });
         } catch (Exception e) {
             LOGGER.warn("Upgrade auth config from env failed, use old value", e);
         }

auth/src/main/java/com/alibaba/nacos/auth/config/AuthModuleStateBuilder.java

@@ -0,0 +1,57 @@
+/*
+ * Copyright 1999-2023 Alibaba Group Holding Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.alibaba.nacos.auth.config;
+
+import com.alibaba.nacos.plugin.auth.spi.server.AuthPluginManager;
+import com.alibaba.nacos.plugin.auth.spi.server.AuthPluginService;
+import com.alibaba.nacos.sys.module.ModuleState;
+import com.alibaba.nacos.sys.module.ModuleStateBuilder;
+import com.alibaba.nacos.sys.utils.ApplicationUtils;
+
+import java.util.Optional;
+
+/**
+ * Module state builder for auth module.
+ *
+ * @author xiweng.yy
+ */
+public class AuthModuleStateBuilder implements ModuleStateBuilder {
+
+    public static final String AUTH_MODULE = "auth";
+
+    public static final String AUTH_ENABLED = "auth_enabled";
+
+    public static final String LOGIN_PAGE_ENABLED = "login_page_enabled";
+
+    public static final String AUTH_SYSTEM_TYPE = "auth_system_type";
+
+    @Override
+    public ModuleState build() {
+        ModuleState result = new ModuleState(AUTH_MODULE);
+        AuthConfigs authConfigs = ApplicationUtils.getBean(AuthConfigs.class);
+        result.newState(AUTH_ENABLED, authConfigs.isAuthEnabled());
+        result.newState(LOGIN_PAGE_ENABLED, isLoginPageEnabled(authConfigs));
+        result.newState(AUTH_SYSTEM_TYPE, authConfigs.getNacosAuthSystemType());
+        return result;
+    }
+
+    private Boolean isLoginPageEnabled(AuthConfigs authConfigs) {
+        Optional<AuthPluginService> authPluginService = AuthPluginManager.getInstance()
+                .findAuthServiceSpiImpl(authConfigs.getNacosAuthSystemType());
+        return authPluginService.map(AuthPluginService::isLoginEnabled).orElse(false);
+    }
+}

auth/src/main/resources/META-INF/services/com.alibaba.nacos.sys.module.ModuleStateBuilder

@@ -0,0 +1,17 @@
+#
+# Copyright 1999-2023 Alibaba Group Holding Ltd.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+com.alibaba.nacos.auth.config.AuthModuleStateBuilder

auth/src/test/java/com/alibaba/nacos/auth/config/AuthModuleStateBuilderTest.java

@@ -0,0 +1,61 @@
+/*
+ * Copyright 1999-2023 Alibaba Group Holding Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.alibaba.nacos.auth.config;
+
+import com.alibaba.nacos.sys.module.ModuleState;
+import com.alibaba.nacos.sys.utils.ApplicationUtils;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.junit.MockitoJUnitRunner;
+import org.springframework.context.ConfigurableApplicationContext;
+
+import static com.alibaba.nacos.auth.config.AuthModuleStateBuilder.AUTH_ENABLED;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.mockito.Mockito.when;
+
+@RunWith(MockitoJUnitRunner.class)
+public class AuthModuleStateBuilderTest {
+
+    @Mock
+    private ConfigurableApplicationContext context;
+
+    @Mock
+    private AuthConfigs authConfigs;
+
+    @Before
+    public void setUp() throws Exception {
+        when(context.getBean(AuthConfigs.class)).thenReturn(authConfigs);
+        ApplicationUtils.injectContext(context);
+        when(authConfigs.getNacosAuthSystemType()).thenReturn("nacos");
+    }
+
+    @After
+    public void tearDown() throws Exception {
+    }
+
+    @Test
+    public void testBuild() {
+        ModuleState actual = new AuthModuleStateBuilder().build();
+        assertFalse((Boolean) actual.getStates().get(AUTH_ENABLED));
+        assertFalse((Boolean) actual.getStates().get("login_page_enabled"));
+        assertEquals("nacos", actual.getStates().get("auth_system_type"));
+    }
+}

client/pom.xml

@@ -30,6 +30,7 @@
 
     <name>nacos-client ${project.version}</name>
     <url>https://nacos.io</url>
+    <description>Nacos client pom.xml file</description>
 
     <dependencies>
 

client/src/main/java/com/alibaba/nacos/client/auth/ram/identify/CredentialService.java

@@ -59,16 +59,15 @@ public static CredentialService getInstance() {
 
     public static CredentialService getInstance(String appName) {
         String key = appName != null ? appName : IdentifyConstants.NO_APP_NAME;
-        CredentialService instance = INSTANCES.get(key);
-        if (instance != null) {
-            return instance;
-        }
-        instance = new CredentialService(appName);
-        CredentialService previous = INSTANCES.putIfAbsent(key, instance);
-        if (previous != null) {
-            instance = previous;
+        if (INSTANCES.get(key) == null) {
+            synchronized (CredentialService.INSTANCES) {
+                if (INSTANCES.get(key) == null) {
+                    CredentialService instance = new CredentialService(appName);
+                    INSTANCES.putIfAbsent(key, instance);
+                }
+            }
         }
-        return instance;
+        return INSTANCES.get(key);
     }
 
     public static CredentialService freeInstance() {