Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default close openssl for client. #10276

Merged
merged 4 commits into from
Apr 7, 2023
Merged

Default close openssl for client. #10276

merged 4 commits into from
Apr 7, 2023

Conversation

shiyiyue1102
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

取消默认使用openssl作为provider,系统会自动选择

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Merging #10276 (7c5890c) into develop (dcb1017) will decrease coverage by 0.06%.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #10276      +/-   ##
=============================================
- Coverage      52.32%   52.27%   -0.06%     
+ Complexity      5171     5155      -16     
=============================================
  Files            874      874              
  Lines          27757    27761       +4     
  Branches        3073     3074       +1     
=============================================
- Hits           14524    14511      -13     
- Misses         11910    11932      +22     
+ Partials        1323     1318       -5     
Impacted Files Coverage Δ
...ba/nacos/common/remote/client/grpc/GrpcClient.java 12.42% <0.00%> (-0.08%) ⬇️
...ava/com/alibaba/nacos/common/remote/TlsConfig.java 14.28% <100.00%> (ø)

... and 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb1017...7c5890c. Read the comment docs.

@KomachiSion KomachiSion added this to the 2.3.0 milestone Apr 7, 2023
@KomachiSion KomachiSion added area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement. labels Apr 7, 2023
@KomachiSion KomachiSion merged commit c519922 into alibaba:develop Apr 7, 2023
@KomachiSion KomachiSion changed the title 取消默认openssl Default close openssl for client. Apr 7, 2023
KomachiSion pushed a commit that referenced this pull request Apr 7, 2023
* 取消默认openssl

* 连接上下文标签中添加tls.enable

* test fix

* checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants