Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant code about 1.x in develop branch. #7930

Closed
realJackSun opened this issue Mar 10, 2022 · 3 comments
Closed

Remove redundant code about 1.x in develop branch. #7930

realJackSun opened this issue Mar 10, 2022 · 3 comments
Labels
kind/code quality
Milestone
2.2.0

Comments

@realJackSun
Copy link
Collaborator

No description provided.

@KomachiSion
Copy link
Collaborator

After PMC & Committer vote for this issue, Community will default close these feature about Compatible with upgrade from 1.X and remove these codes after 2.2 version.

@KomachiSion KomachiSion added this to the 2.1.0 milestone Mar 28, 2022
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Mar 28, 2022
@KomachiSion
For alibaba#7930. Default close support upgrade from 1.X feature(doub…
a5e8395 
…le write and old raft).
@KomachiSion KomachiSion mentioned this issue Mar 28, 2022
Merged
5 tasks
KomachiSion added a commit that referenced this issue Mar 28, 2022
@KomachiSion
For #7930. Default close support upgrade from 1.X feature. (#8016)
26ef773 
* For #7930. Default close support upgrade from 1.X feature(double write and old raft).

* Fix use still use old raft when close upgrade feature.

* UpgradeJudgement subscribe member change event only open upgrade feature.
@wangdongyun
Copy link

After PMC & Committer vote for this issue, Community will default close these feature about Compatible with upgrade from 1.X and remove these codes after 2.2 version.

1.x 和 2.x 代码同时存在，太乱了

@KomachiSion KomachiSion modified the milestones: 2.1.0, 2.1.1 Apr 29, 2022
@yangzhongj
Copy link

同意云歌说法，建议直接干掉，也促使用户升级

@KomachiSion KomachiSion modified the milestones: 2.1.1, 2.1.2 Aug 10, 2022
@KomachiSion KomachiSion mentioned this issue Aug 29, 2022
Merged
5 tasks
@KomachiSion KomachiSion modified the milestones: 2.1.2, 2.2.0 Oct 10, 2022
@KomachiSion KomachiSion mentioned this issue Oct 21, 2022
Merged
5 tasks
@KomachiSion KomachiSion mentioned this issue Oct 25, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/code quality
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
4 participants
@yangzhongj @wangdongyun @KomachiSion @realJackSun