Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe rename instanceFilter.js to InstanceFilter.js because some machines are case sensitive. #7498

Closed
CherishCai opened this issue Dec 24, 2021 · 3 comments
Closed

Maybe rename instanceFilter.js to InstanceFilter.js because some machines are case sensitive. #7498

CherishCai opened this issue Dec 24, 2021 · 3 comments

Comments

@CherishCai
Copy link
Contributor

Some machines are case sensitive.
so
console-ui/src/pages/ServiceManagement/ServiceDetail/instanceFilter.js
to
console-ui/src/pages/ServiceManagement/ServiceDetail/InstanceFilter.js

After renaming, build main.js without any changes.
@li-xiao-shuang
Copy link
Collaborator

You can try to deal with it

CherishCai added a commit to CherishCai/nacos that referenced this issue Dec 28, 2021
@CherishCai
feat(alibaba#7498): Some machines are case sensitive, so rename insta…
06b5b6d 
…nceFilter.js to InstanceFilter.js. build main.js without any changes.
@CherishCai CherishCai mentioned this issue Dec 28, 2021
Closed
@CherishCai
Copy link
Contributor Author

But now main.css and main.js not the newest in v1.x-develop? When npm run build will get new files.

CherishCai added a commit to CherishCai/nacos that referenced this issue Apr 22, 2022
@CherishCai
feat(alibaba#7498): Some machines are case sensitive, so rename insta…
7d9dcdc 
…nceFilter.js to InstanceFilter.js
@CherishCai CherishCai mentioned this issue Apr 22, 2022
Merged
KomachiSion pushed a commit that referenced this issue Apr 26, 2022
@CherishCai
feat(#7498): Some machines are case sensitive, so rename instanceFilt…
a170a69 
…er.js to InstanceFilter.js (#8236)
@ilaotan
Copy link

ilaotan commented Sep 30, 2022

after rename, centos build is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ilaotan @CherishCai @li-xiao-shuang @KomachiSion