Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless service declaration "RequestStream" in grpc proto file #7193

Closed
lpaz010 opened this issue Nov 8, 2021 · 1 comment
Closed

Remove useless service declaration "RequestStream" in grpc proto file #7193

lpaz010 opened this issue Nov 8, 2021 · 1 comment
Labels
expired No active for a long time

Comments

@lpaz010
Copy link
Contributor

lpaz010 commented Nov 8, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
#7163 removed RequestStreamGrpc.java, so remove proto file declaration service RequestStream.

Describe the solution you'd like
remove useless service declaration service RequestStream in grpc proto file located on nacos_grpc_service.proto

Describe alternatives you've considered
none

Additional context
none
@lpaz010 lpaz010 changed the title Remove useless grpc proto file of service declaration "RequestStream" Remove useless service declaration "RequestStream" in grpc proto file Nov 8, 2021
@lpaz010 lpaz010 mentioned this issue Nov 8, 2021
Closed
5 tasks
lpaz010 added a commit to lpaz010/nacos that referenced this issue Nov 8, 2021
@lpaz010
[ISSUE alibaba#7163] remove useless service declaration "RequestStrea…
fa85ea9 
…m" in grpc proto file (alibaba#7193)
@lpaz010 lpaz010 mentioned this issue Nov 8, 2021
Merged
5 tasks
shiyiyue1102 pushed a commit that referenced this issue Nov 16, 2021
@lpaz010
[ISSUE #7163] remove useless service declaration "RequestStream" in g…
0ecb6e8 
…rpc proto file (#7193) (#7197)
@stale
Copy link

stale bot commented Jun 19, 2022

Thanks for your feedback and contribution. But the issue/pull request has not had recent activity more than 180 days. This issue/pull request will be closed if no further activity occurs 7 days later.
We may solve this issue in new version. So can you upgrade to newest version and retry?
If there are still issues or want to contribute again. Please create new issue or pull request again.

@stale stale bot added the expired No active for a long time label Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
expired No active for a long time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KomachiSion @lpaz010