Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: better async function in useAPI #83

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

popomore
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Sep 30, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://hooks-git-fork-popomore-improve-useasync.umijs.now.sh

@vercel vercel bot temporarily deployed to staging September 30, 2019 18:29 Inactive
@popomore popomore changed the title refactor: better async function in useAsync refactor: better async function in useAPI Sep 30, 2019
@brickspert brickspert requested a review from ttys026 October 7, 2019 02:22
Copy link
Collaborator

@ttys026 ttys026 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,错误在 useAsync 里面已经 catch 过了。这里应该直接 return

@ttys026 ttys026 merged commit d5d2709 into alibaba:master Oct 7, 2019
brickspert added a commit that referenced this pull request Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants