Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useHistoryTravel): add manual update option #2278

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Debbl
Copy link

@Debbl Debbl commented Aug 2, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve: #2272

💡 Background and solution

需要手动的提交历史记录。为了更好的兼容性,没有改变 maxLength 的传递方式, 本地跑了我自己写的测试,运行后没有看到 dome4 的效果。

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@CLAassistant
Copy link

CLAassistant commented Aug 2, 2023

CLA assistant check
All committers have signed the CLA.

@liuyib
Copy link
Collaborator

liuyib commented Aug 3, 2023

第二个参数处理成 options 和我的想法完全一致,秀哦~,review 了一部分,剩下的回头有空再继续看

@liuyib liuyib self-requested a review August 3, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

是否考虑添加一个 useManualHistoryTravel 来手动的记录状态
3 participants